copy plugin: Support globs
Metadata
Current evaluation
Merged PR #108 (commit 8294647d6; merge 639d60c41), adding glob support to the copy plugin and replacing cp with Python APIs.
Resolution: closed resolved
Reason: PR #108 was merged via merge commit 639d60c41. Implementation commit 8294647d6 added copy-plugin glob handling using Python APIs instead of invoking cp.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This also removes the call to `cp` and uses plain python APIs
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #108 (commit 8294647d6; merge 639d60c41), adding glob support to the copy plugin and replacing cp with Python APIs. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#108: added glob support to the copy plugin and replaced cp with Python APIs, extracted from the broader unmerged #91. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Adds glob support to the copy plugin and replaces the cp command with native Python APIs. Approved after a reviewer suggested using glob.has_magic to improve error messages. Partially extracted from a larger PR. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Replaces the shell cp command with native Python APIs to add glob pattern support to the copy plugin. Approved by @chipaca with suggestions to refine error handling using glob.has_magic. Partial extraction from a larger PR. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#91
(confidence 98%)
PR #108 was described by its author as a partial extraction from the broader unmerged PR #91.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #26 copy plugin doesn't support globs | snapcraft | closed | Copy-plugin source globs were implemented by merged PR #108 (commit 8294647d6, merge 639d60c41); tracking later moved back to Launchpad. | |
| #1478054 copy plugin doesn't support globs | snapcraft (launchpad) | closed | Launchpad bug 1478054 (copy plugin lacks src glob support) was migrated to GitHub issue ubuntu-core/snapcraft#26 and fixed by merged PR #108, commit 8294647d6, which replaced cp with Python glob calls and added a unit test. | |
| #91 Support globs in copy plugin | snapcraft | closed | Closed unmerged after source management was split out; narrower copy-plugin glob support landed in #108 via commit 8294647d6. |