Support globs in copy plugin
Metadata
Current evaluation
Closed unmerged after source management was split out; narrower copy-plugin glob support landed in #108 via commit 8294647d6.
Resolution: closed superseded
Reason: The maintainer rejected the broader source-handling redesign and requested a copy-plugin-only change. PR #91 was closed unmerged; its remaining glob work was implemented by merged PR #108 in commit 8294647d6 (merge 639d60c41).
Evaluated by: mr-cal-bot
No scores available.
Issue body
Change to support globs in copy plugin. But I made another change in that the copy plugin now supports the source property. I think this is a good thing because you can now copy from a github repository for instance. But it does increase the amount of base syntax required to do a basic copy instance. Open to ideas on how to make that better.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after source management was split out; narrower copy-plugin glob support landed in #108 via commit 8294647d6. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged by sergiusens on 2015-11-23, who asked to scope it to copy-plugin globs only. Glob support landed separately in merged PR #108 (commit 8294647d6); source handling moved to core later in #923. | |
| stealth/space-bunny-alpha | — | closed superseded | PR #91 (glob support plus a plugin-level `source` keyword for copy) was closed unmerged by sergiusens on 2015-11-23; the narrower glob-only version landed as merged PR #108 (commit 8294647d6). | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; source handling was split out, and narrower copy-plugin glob support landed in #108 via commit 8294647d6. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. Reviewers rejected the source property addition, deeming it an architectural mismatch. The PR was closed to allow a resubmission focusing strictly on glob support, deferring source management to a separate discussion. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging. Maintainer rejected a plugin-level source property, preferring it as a builtin keyword managed by the lifecycle handler. Suggested splitting to focus on globs, but ultimately closed the PR. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcraft#108
(confidence 100%)
Implemented the copy-plugin-only glob support omitted from #91.
-
Related To:
snapcraft#26
(confidence 98%)
Original copy-plugin glob issue linked to #91 and resolved by #108.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #26 copy plugin doesn't support globs | snapcraft | closed | Copy-plugin source globs were implemented by merged PR #108 (commit 8294647d6, merge 639d60c41); tracking later moved back to Launchpad. | |
| #108 copy plugin: Support globs | snapcraft | merged | Merged PR #108 (commit 8294647d6; merge 639d60c41), adding glob support to the copy plugin and replacing cp with Python APIs. | |
| #1478054 copy plugin doesn't support globs | snapcraft (launchpad) | closed | Launchpad bug 1478054 (copy plugin lacks src glob support) was migrated to GitHub issue ubuntu-core/snapcraft#26 and fixed by merged PR #108, commit 8294647d6, which replaced cp with Python glob calls and added a unit test. | |
| #420 Extends copy plugin to support source and destination | snapcraft | closed | Closed unmerged because its Copy plugin changes were folded into canonical/snapcraft#416, which merged as commit 9a6684ce7 and added remote-source support. |