← Back to issue list

Plainbox providers run validate

View original Github issue

Metadata

Project
snapcraft
Number
#1095
Type
pull request
State
merged
Author
jocave
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 725546824, making plainbox-provider builds run validate with PROVIDERPATH support and an integration test to catch invalid providers and jobs.

Resolution: closed resolved

Reason: PR snapcraft#1095 was approved and merged as commit 725546824, adding build-time Plainbox validation, cross-provider job resolution via PROVIDERPATH, and integration coverage.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Modify the plainbox-provider plugin to run the "validate" command during the build step to ensure buggy providers don't make it in to checkbox snap packages. As providers can reference jobs from other providers (i.e. have a dependency on that provider) the environment has a variable PROVIDERPATH populated. Coupled with appropriate use of the "after" keyword this allows "validate" steps to identify that jobs are defined correctly. An integration test to confirm this functionality is included. LP: [#1660692](https://bugs.launchpad.net/snapcraft/+bug/1660692)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 725546824, making plainbox-provider builds run validate with PROVIDERPATH support and an integration test to catch invalid providers and jobs.
stealth/space-bunny-alpha — closed resolved PR #1095 merged as commit 725546824, adding build-time plainbox validation, PROVIDERPATH support and an integration test.
qwen/qwen3.6-35b-a3b — — Merged. Adds a build-time validation step to the plainbox-provider plugin to prevent buggy providers from packaging into checkbox snaps. Handles cross-provider dependencies and includes an integration test. Approved after minor test naming adjustments.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updates the plainbox-provider plugin to run the validate command during builds, preventing buggy providers from packaging into checkbox snaps. Incorporates test naming feedback and resolves LP #1660692.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1660692 The plainbox-provider plug should run "validate" during the build step snapcraft (launchpad) closed Plainbox provider validation was added during builds by snapcore/snapcraft#1095, commit 725546824.
81%
#1611 plainbox-provider plugin: init PROVIDERPATH snapcraft merged Merged #1611 as 467e3f040, initializing PROVIDERPATH so build-host providers cannot affect plainbox-provider validation; fixes LP #1722833.
79%
#1722833 plainbox-provider plugin: validation of the first provider in a snap can fail based on host system configuration snapcraft (launchpad) closed Host-dependent plainbox-provider validation failure was fixed by merged snapcraft PR #1611 (commit 467e3f040, "plainbox-provider plugin: init PROVIDERPATH"), which initializes PROVIDERPATH so host provider/test definitions can't leak into the build.
75%