← Back to issue list

catkin plugin: produce build-ready staging area.

View original Github issue

Metadata

Project
snapcraft
Number
#1130
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1130 (commit e34b7ab19) makes the Catkin plugin rewrite ROS-specific paths after building, creating a staging area reusable by later parts and fixing LP #1663385.

Resolution: closed resolved

Reason: PR #1130 was merged as e34b7ab19 after maintainer approval. It moves ROS-specific path massaging until after the build so staged files no longer reference the old install directory.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Currently the Catkin plugin massages some ROS-specific files in order to get it to build from within the part's install directory. This works well enough, but produces a staging area that, if used to build more parts in the future, will attempt to use the old install directory. This PR fixes LP: [#1663385](https://bugs.launchpad.net/snapcraft/+bug/1663385) by updating the Catkin plugin such that, once the build has completed, these files are massaged to be usable from the staging area.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1130 (commit e34b7ab19) makes the Catkin plugin rewrite ROS-specific paths after building, creating a staging area reusable by later parts and fixing LP #1663385.
stealth/space-bunny-alpha — closed resolved Merged PR #1130 (commit e34b7ab19) made the Catkin plugin rewrite ROS-specific files after builds, producing a staging area ready for downstream parts.
stealth/space-bunny-alpha — closed resolved Merged PR #1130 (commit e34b7ab19) updated the Catkin plugin to rewrite ROS-specific files after building, producing a staging area ready for further part builds and resolving LP #1663385.
qwen/qwen3.6-35b-a3b — — Merged update to the Catkin plugin generating a build-ready staging area by adjusting ROS files post-build, resolving LP #1663385. Approved, passed CI, and modified two files to prevent future parts from referencing the old install directory.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updates the Catkin plugin to adjust ROS files post-build, creating a staging area ready for subsequent part builds. Resolves Launchpad bug #1663385. Approved after tests passed, ignoring one unrelated Xenial failure.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#1663385 Catkin plugin: Staging area not suitable for building other parts snapcraft (launchpad) closed Catkin staging output was made reusable by later parts: merged snapcraft#1130 rewrote ROS-specific paths after building, fixing LP #1663385.
88%
#1070 catkin plugin: don't stage compilers. snapcraft merged Merged PR #1070 as commit ea8736af4, moving required Catkin compilers to an alternate work area so they are available during builds but excluded from final snaps; fixes LP #1658828.
76%
#2525 catkin plugin: check stage-snaps for ROS dependencies snapcraft merged Merged #2525 as d1c5f1b00, updating the catkin plugin to honor ROS dependencies supplied by stage-snaps and avoid redundant fetches.
75%
#1239 catkin plugin: create completely valid environment snapcraft merged Merged PR #1239 (commit 449ad2634) fixing LP: #1674487: catkin plugin now sets LD_LIBRARY_PATH and a valid ROS_HOME before sourcing setup.sh, so build-time env matches runtime.
74%
#1658828 Catkin plugin stages compilers snapcraft (launchpad) closed Catkin no longer stages compilers: snapcore/snapcraft#1070 (ea8736af4) moved them to an alternate work area, keeping compiler bloat out of ROS snaps.
73%
#1367 catkin plugin: add support for ROS Lunar snapcraft merged Merged PR #1367 (commit ba722e847), adding ROS Lunar support and the lsb-release build workaround for Launchpad bug #1677002.
72%
#881 Catkin plugin: Python nodes require gcc/g++ too. snapcraft merged Merged as commit 2f0c8ba04: catkin plugin now stages gcc/g++ unconditionally at the start of the build (instead of only when roscpp is a dependency), fixing LP bug #1638317.
71%
#1638317 Catkin plugin doesn't build pure python workspaces snapcraft (launchpad) closed Catkin plugin only staged g++ when roscpp was a dependency, breaking pure-Python ROS workspaces. Fixed by snapcore/snapcraft PR #881 (merged as 2f0c8ba04), staging gcc/g++ unconditionally; issue closed by maintainer ~kyrofa.
70%
#1743 catkin plugin: support building entire workspace snapcraft merged Merged #1743 in commit ec4cac26a, making catkin-packages optional so the Catkin plugin builds the entire workspace when omitted; this also resolves snapcraft#1713.
70%