← Back to issue list

Catkin plugin: Python nodes require gcc/g++ too.

View original Github issue

Metadata

Project
snapcraft
Number
#881
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for Launchpad bug #1638317 updating the Catkin plugin to unconditionally stage gcc and g++ at the beginning. This ensures Python nodes compile correctly regardless of roscpp dependencies. The change modifies two files.

Suggested action:

No scores available.

Issue body

This PR fixes LP: [#1638317](https://bugs.launchpad.net/snapcraft/+bug/1638317) by staging them at the beginning instead of doing so dependent upon whether `roscpp` is in the dependency list.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for Launchpad bug #1638317 updating the Catkin plugin to unconditionally stage gcc and g++ at the beginning. This ensures Python nodes compile correctly regardless of roscpp dependencies. The change modifies two files.
qwen3.6-35b-a3b-mtp-q6 Merged. The catkin plugin now stages gcc and g++ for Python nodes at the start of the build, resolving Launchpad bug #1638317 by removing the conditional roscpp dependency.
qwen3.6-35b-a3b-mtp-q6 Merged fix for the Catkin plugin ensuring Python nodes always stage gcc/g++. Resolves Launchpad bug #1638317 by unconditionally staging compilers at build start instead of conditionally based on roscpp dependencies.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2525 catkin plugin: check stage-snaps for ROS dependencies snapcraft merged Merged to master. Updates the catkin plugin to check stage-snaps for ROS dependencies, preventing redundant fetching by treating them like underlays. Resolves Launchpad bug #1823788. Approved, passed CI, and merged.
72%
#840 Catkin plugin: build with in-snap python. snapcraft merged Merged after approval. Resolves LP #1628990 by configuring the catkin plugin to use in-snap Python for both build and run times. Adds gcc, libc-dev, and make as build dependencies.
72%
#1130 catkin plugin: produce build-ready staging area. snapcraft merged Merged update to the Catkin plugin generating a build-ready staging area by adjusting ROS files post-build, resolving LP #1663385. Approved, passed CI, and modified two files to prevent future parts from referencing the old install directory.
71%
#152 Catkin plugin: Add support for ROS tools. snapcraft merged Merged Catkin plugin updates to properly install ROS packages, include non-source files, and enable ROS tools via an updated wrapper environment. Resolved an xml2-config conflict while planning to remove the redundant roscore plugin. Tests doubled.
71%
#1070 catkin plugin: don't stage compilers. snapcraft merged Merged to master. The catkin plugin now routes compilers to an alternate working area instead of staging them, resolving LP #1658828 and preventing their inclusion in the final snap. Approved, passed CI, and merged.
70%
#232 Catkin plugin: Use in-snap python instead of OS-provided. snapcraft merged Merged a fix for the Catkin plugin failing on Ubuntu Xenial due to removed OS Python 2. Shebangs now use /usr/bin/env python and 10.ros.sh uses path-based Python, resolving review-flagged file conflicts and missing attributes.
70%