lifecycle: hardcode test_core_snap's PATH.
Metadata
Current evaluation
Closed unmerged: the hardcoded mksquashfs PATH workaround was abandoned; the underlying environment-variable leak was instead fixed by #1133 (c0b0f9752).
Resolution: closed superseded
Reason: PR #1131 was closed without merging after its author said, "Yeah let's toast this." Merged PR #1133 (commit c0b0f9752) fixed the test modifying environment variables, addressing the underlying PATH corruption instead of hardcoding a path.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This PR fixes LP: [#1663396](https://bugs.launchpad.net/snapcraft/+bug/1663396) by no longer expanding the PATH but simply hardcoding the directory containing `mksquashfs`. Not an ideal fix because something is still making the PATH garbage, but the suite passes again.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged: the hardcoded mksquashfs PATH workaround was abandoned; the underlying environment-variable leak was instead fixed by #1133 (c0b0f9752). | |
| stealth/space-bunny-alpha | — | closed superseded | PR #1131 (hardcode mksquashfs PATH in test_core_snap for LP #1663396) was closed unmerged — the author called it a non-ideal hack and toasted it after the Tomcat/Maven failure (LP #1663434); the root cause was instead fixed by #1133 (c0b0f9752). | |
| stealth/space-bunny-alpha | — | closed stale | PR #1131 (kyrofa) hardcoded the mksquashfs dir in test_core_snap's PATH as a workaround for LP: #1663396; never merged — reviewer requested changes and the author closed it in Feb 2017 saying "Yeah let's toast this". | |
| stealth/space-bunny-alpha | — | closed stale | Hardcoded mksquashfs PATH workaround was abandoned unmerged after a separate Tomcat Maven failure (LP #1663434); the maintainer said, "Yeah let's toast this." | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The maintainer abandoned the pull request after another test failure was reported, deciding to discard the proposed PATH hardcoding fix. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging. The PATH hardcoding workaround was abandoned after persistent test failures, with the maintainer deciding to discard the changes. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcraft#1133
(confidence 96%)
Merged fix for the environment-variable test leak underlying the PATH problem.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1663396 Lifecycle's test_core_snap environment gets corrupted by something earlier in the suite | snapcraft (launchpad) | closed | Fixed by merged PR canonical/snapcraft#1133 (commit c0b0f9752), eliminating a test's PATH/environment-variable leak that prevented mksquashfs from being found. |