← Back to issue list

tests: fix the test that was modifying the environment variables

View original Github issue

Metadata

Project
snapcraft
Number
#1133
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for a test modifying environment variables. Adds an assertion to fail when PATH is empty and uses os.environ instead of grep. Approved by two reviewers, resolves LP #1663396, and applies +3/-2 lines.

Suggested action:

No scores available.

Issue body

LP: [#1663396](https://bugs.launchpad.net/snapcraft/+bug/1663396)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for a test modifying environment variables. Adds an assertion to fail when PATH is empty and uses os.environ instead of grep. Approved by two reviewers, resolves LP #1663396, and applies +3/-2 lines.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for a test that incorrectly modified environment variables. An assertion was added to detect empty PATH values, isolating the problematic test and resolving Launchpad bug #1663396.
qwen3.6-35b-a3b-mtp-q6 Pull request merged, fixing a test that incorrectly modified environment variables. Added an assertion to detect empty PATH values, resolving LP #1663396.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1125 tests: fix the env vars passed to the docker container in travis snapcraft merged Merged a fix correcting environment variables passed to the Docker container in Travis CI tests. Approved by one reviewer, the change updates one file (+4/-2 lines) and resolves Launchpad bug #1663088.
76%
#13 tests: Ensure coverage gets per-environment filenames starbase merged Merged a single-line test update ensuring coverage tools generate per-environment filenames. Approved by one reviewer with no comments.
75%
#1398 tests: fix issues with python 3.6 snapcraft merged Merged fix for Python 3.6 test compatibility. Approved by one reviewer, modified three files (+34/-7). Resolves Launchpad bug #1699009.
73%
#1541 tests: fix the TEST_STORE environment variable snapcraft merged Merged a fix for the TEST_STORE environment variable. The change prevents skip decorators from running before test setup, resolving unexpected behavior. Approved by three reviewers and squashed prior to merge.
73%
#4036 tests: ensure coverage is set per tox env snapcraft merged Merged a single-file change (+3/-2 lines) to set test coverage per tox environment. Approved by a reviewer, passed CI, and integrated without changing coverage metrics.
70%