tests: fix the test that was modifying the environment variables
Metadata
Current evaluation
Merged PR #1133 (commit c0b0f9752), fixing a test that leaked PATH/environment-variable changes and guarding against an empty PATH.
Resolution: closed resolved
Reason: PR #1133 was approved and merged as commit c0b0f9752, resolving Launchpad bug #1663396 by fixing the environment-mutating test and adding an assertion that detects an empty PATH.
Evaluated by: mr-cal-bot
No scores available.
Issue body
LP: [#1663396](https://bugs.launchpad.net/snapcraft/+bug/1663396)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1133 (commit c0b0f9752), fixing a test that leaked PATH/environment-variable changes and guarding against an empty PATH. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1133 in commit c0b0f9752, fixing test-side environment mutation and adding a guard against an empty PATH. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit c0b0f9752 (snapcraft#1133, Feb 2017). Fixed a unit test that mutated environment variables and leaked state to later tests; added a setup-test assertion guarding against empty PATH. Closes LP #1663396. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#1133 (commit c0b0f9752), fixing a test that modified environment variables and guarding against an empty PATH. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for a test modifying environment variables. Adds an assertion to fail when PATH is empty and uses os.environ instead of grep. Approved by two reviewers, resolves LP #1663396, and applies +3/-2 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for a test that incorrectly modified environment variables. An assertion was added to detect empty PATH values, isolating the problematic test and resolving Launchpad bug #1663396. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1125 tests: fix the env vars passed to the docker container in travis | snapcraft | merged | Merged PR #1125 in commit 44834f539, fixing Travis CI to pass required environment variables into its Docker test container and resolving LP #1663088. | |
| #1083 ci: fix spread test missing PATH | charmcraft | merged | Merged PR #1083 as commit 13c96b83, fixing the missing PATH in Spread tests; configure and remove tests then passed. | |
| #19 tests: update test environments for coverage | craft-archives | merged | Merged PR #19 as commit 584f098, updating four test-environment files; Codecov reported 100% diff coverage. | |
| #13 tests: Ensure coverage gets per-environment filenames | starbase | merged | Merged PR #13 added test configuration for distinct per-environment coverage filenames; change landed via commit 28bb9d8 and merge commit 7e30bab. | |
| #181 fix: rename TEST_COMMAND_PREFIX | starflow | closed | Merged PR #181, renaming the test command prefix to namespace discovered environment variables; all CI checks passed. | |
| #1541 tests: fix the TEST_STORE environment variable | snapcraft | merged | Merged in PR #1541 as commit a36d3e053, fixing TEST_STORE handling so tests no longer skip before the empty value is translated to the fake store. |