kernel plugin: if kernel's target == NULL, use per-arch default target
Metadata
Current evaluation
Closed unmerged: superseded by snapcraft PR #1209, merged as commit 2b6aee1e9, which adds per-arch kernel build targets (bzImage/zImage/Image.gz) plus unit tests for LP #1665659.
Resolution: closed superseded
Reason: Maintainer sergiusens closed this PR on 2017-03-22 stating that #1209 replaces it, fixing issues and adding tests; #1209 was merged as commit 2b6aee1e9 implementing the same per-arch default kernel targets.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Linux's per-arch default targets are:
i386/amd64: bzImage
arm: zImage
arm64: Image.gz
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
LP: #1665659
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged: superseded by snapcraft PR #1209, merged as commit 2b6aee1e9, which adds per-arch kernel build targets (bzImage/zImage/Image.gz) plus unit tests for LP #1665659. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by merged snapcraft PR #1209 (commit 2b6aee1e9), which implemented per-architecture kernel targets and added tests. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by merged canonical/snapcraft#1209, which added per-architecture default kernel targets and unit tests. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by merged PR canonical/snapcraft#1209 (commit 2b6aee1e9), which added per-architecture default kernel targets and tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by pull request #1209, which implements the per-arch default target logic, resolves related issues, and includes required unit tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by pull request #1209, which implements per-architecture default kernel targets, fixes related issues, and adds the requested unit tests. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#1209
(confidence 98%)
Closing comment explicitly says '#1209 replaces this, fixes some issues and adds tests'; #1209 merged as commit 2b6aee1e9.
-
Likely Fixed By:
canonical/snapcraft#1209
(confidence 90%)
Commit 2b6aee1e9 added per-arch default kernel targets in the kernel plugin, shipping the behaviour this PR proposed.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1665659 kernel plugin: if kernel's target == NULL, use per-arch default target | snapcraft (launchpad) | closed | Merged canonical/snapcraft#1209 (commit 2b6aee1e9), adding per-architecture kernel build targets when no target is configured. | |
| #1136 kernel plugin: if kernel's target == NULL, use per-arch default target | snapcraft | closed | Closed unmerged; the equivalent kernel-plugin change was merged in #1209 as commit 2b6aee1e9, adding architecture-specific default build targets. | |
| #1209 kernel plugin: use default per arch targets. | snapcraft | merged | Merged PR #1209 as commit 2b6aee1e9, adding architecture-specific kernel build targets when none is configured (LP #1665659). | |
| #1604801 kernel plugin: pick the correct kernel-image-target per architecture | snapcraft (launchpad) | closed | Architecture-specific kernel image targets were merged in snapcraft PR #689 (f0a19ebcc), enabling one kernel snap definition to build amd64, arm64, and armhf. | |
| #689 kernel plugin: kernel targets depending on debarch | snapcraft | merged | Merged as f0a19ebcc, adding architecture-specific kernel image targets so one snapcraft.yaml builds amd64, arm64 and armhf kernels. | |
| #1700069 kernel plugin: add implicit kernel targets for powerpc, ppc64el and s390x | snapcraft (launchpad) | closed | Feature request to add implicit/default kernel build targets for powerpc, ppc64el and s390x was implemented in merged PR canonical/snapcraft#1377 (commit 6bcfc2ec4) and released in snapcraft 2.33; issue closed as fixed. | |
| #1377 kernel plugin: add default targets per powerpc, ppc64el and s390x | snapcraft | merged | Merged as commit 6bcfc2ec4, adding default kernel targets for powerpc, ppc64el, and s390x. | |
| #1606903 kernel plugin: can't snap a kernel using launchpad | snapcraft (launchpad) | closed | Fixed by merged PR canonical/snapcraft#903 (commit 603948e1d), allowing Store part downloads without snapcraft login and resolving Launchpad kernel builds. | |
| #1242 kernel_plugin: use CROSS_COMPILE to override the default toolchain | snapcraft | merged | Merged snapcore/snapcraft#1242, letting kernel_plugin honor CROSS_COMPILE to override the default toolchain; commit c096cb92f. | |
| #1748 kernel plugin: don't assume /lib/firmware is present if !kernel-with-firmware | snapcraft | closed | PR #1748 (kernel plugin /lib/firmware hotfix, LP #1733564) was closed as superseded by canonical/snapcraft#1750, merged as commit 2d16ac3c0 to skip /lib/firmware handling when kernel-with-firmware is false. |