← Back to issue list

kernel_plugin: use CROSS_COMPILE to override the default toolchain

View original Github issue

Metadata

Project
snapcraft
Number
#1242
Type
pull request
State
merged
Author
piso77
Labels
Created
Updated
Closed

Current evaluation

Merged. Enables kernel plugin toolchain override via CROSS_COMPILE. A unit test replaced the requested manual test to verify the override. A maintainer applied a minor environment variable fix prior to merge. (+17/-2 lines, 2 files)

Suggested action:

No scores available.

Issue body

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> LP: #1680863

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Enables kernel plugin toolchain override via CROSS_COMPILE. A unit test replaced the requested manual test to verify the override. A maintainer applied a minor environment variable fix prior to merge. (+17/-2 lines, 2 files)
qwen3.6-35b-a3b-mtp-q6 Merged update enabling CROSS_COMPILE to override the kernel plugin default toolchain. Includes unit tests for the override. Approved after a minor environment configuration fix.
qwen3.6-35b-a3b-mtp-q6 Merged after adding unit tests to verify CROSS_COMPILE overrides the default toolchain. A reviewer applied a final fix to environment variable handling before approval. The change enables custom toolchain selection for kernel builds.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1150 kernel plugin: rework MAKEFLAGS from the environment snapcraft merged Merged. The kernel plugin now strips the MAKEFLAGS environment variable to prevent nested Makefile conflicts. Approved by a reviewer, passes CI, and resolves LP #1665661.
72%
#1874 kbuild: pick up CROSS_COMPILE only if it's not empty snapcraft merged Merged a fix preventing kbuild FTBFS when CROSS_COMPILE is empty. The plugin now only applies the variable if non-empty, falling back to the default toolchain, and includes a regression unit test.
71%