← Back to issue list

kernel_plugin: use CROSS_COMPILE to override the default toolchain

View original Github issue

Metadata

Project
snapcraft
Number
#1242
Type
pull request
State
merged
Author
piso77
Labels
—
Created
Updated
Closed

Current evaluation

Merged snapcore/snapcraft#1242, letting kernel_plugin honor CROSS_COMPILE to override the default toolchain; commit c096cb92f.

Resolution: closed resolved

Reason: PR snapcore/snapcraft#1242 was approved and merged into master as commit c096cb92f. Unit coverage verified that a caller-supplied CROSS_COMPILE replaces the default toolchain prefix.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> LP: #1680863

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged snapcore/snapcraft#1242, letting kernel_plugin honor CROSS_COMPILE to override the default toolchain; commit c096cb92f.
stealth/space-bunny-alpha — closed resolved Merged PR #1242 in commit c096cb92f, allowing CROSS_COMPILE to override the kernel plugin’s default toolchain, with a unit test covering the override.
stealth/space-bunny-alpha — closed resolved Merged in #1242: kernel_plugin now uses CROSS_COMPILE to override its default toolchain, with unit-test coverage and a final environment-setup fix.
stealth/space-bunny-alpha — closed resolved Merged in PR #1242 as commit c096cb92f, allowing the kernel plugin to override its default toolchain with CROSS_COMPILE and adding unit-test coverage.
qwen/qwen3.6-35b-a3b — — Merged. Enables kernel plugin toolchain override via CROSS_COMPILE. A unit test replaced the requested manual test to verify the override. A maintainer applied a minor environment variable fix prior to merge. (+17/-2 lines, 2 files)
qwen3.6-35b-a3b-mtp-q6 — — Merged update enabling CROSS_COMPILE to override the kernel plugin default toolchain. Includes unit tests for the override. Approved after a minor environment configuration fix.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1680863 let the user set the toolchain with CROSS_COMPILE snapcraft (launchpad) closed CROSS_COMPILE toolchain overrides were merged for kernel_plugin in snapcore/snapcraft#1242 (commit c096cb92f), with unit-test coverage.
85%
#1743591 kbuild: pick up CROSS_COMPILE only if it's not empty snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#1874 in commit aa116ef75: empty CROSS_COMPILE is ignored, allowing fallback to the default toolchain.
74%
#1149 kernel plugin: if kernel's target == NULL, use per-arch default target snapcraft closed Closed unmerged: superseded by snapcraft PR #1209, merged as commit 2b6aee1e9, which adds per-arch kernel build targets (bzImage/zImage/Image.gz) plus unit tests for LP #1665659.
72%
#1665661 kernel plugin: remove MAKEFLAGS from the environment snapcraft (launchpad) closed Fixed by merged PR canonical/snapcraft#1150 (commit 1409ed25c), removing MAKEFLAGS from the kernel plugin build environment to prevent nested Linux Makefile conflicts.
72%
#1874 kbuild: pick up CROSS_COMPILE only if it's not empty snapcraft merged Merged in snapcraft#1874 (aa116ef75): kbuild now ignores an empty CROSS_COMPILE and uses the default toolchain, preventing cross-build FTBFS.
71%
#1606903 kernel plugin: can't snap a kernel using launchpad snapcraft (launchpad) closed Fixed by merged PR canonical/snapcraft#903 (commit 603948e1d), allowing Store part downloads without snapcraft login and resolving Launchpad kernel builds.
71%
#6418 core26: kernel plugin fails to run snapcraft closed Fixed by merged PR canonical/snapcraft#6425 (commit be405aad6), updating the kernel plugin to handle modules packaged under usr/lib on usrmerged core26 systems.
71%
#1665659 kernel plugin: if kernel's target == NULL, use per-arch default target snapcraft (launchpad) closed Merged canonical/snapcraft#1209 (commit 2b6aee1e9), adding per-architecture kernel build targets when no target is configured.
70%