← Back to issue list

demos: add ROS content sharing demo

View original Github issue

Metadata

Project
snapcraft
Number
#1186
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged changes adding a ROS content sharing demo snap and automating the standalone ROS demo test, resolving Launchpad bug #1664776. Approved by one reviewer, modified 15 files, building upon PR #1140.

Suggested action:

No scores available.

Issue body

This PR finishes off LP: [#1664776](https://bugs.launchpad.net/snapcraft/+bug/1664776) by adding a demo snap for ROS content sharing. It also updates the standalone ROS demo to run the command, removing the need for a manual test. **Note:** This PR builds upon #1140.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes adding a ROS content sharing demo snap and automating the standalone ROS demo test, resolving Launchpad bug #1664776. Approved by one reviewer, modified 15 files, building upon PR #1140.
qwen3.6-35b-a3b-mtp-q6 Merged to close Launchpad bug #1664776 by adding a ROS content sharing demo snap and automating the standalone ROS demo test, building upon PR #1140.
qwen3.6-35b-a3b-mtp-q6 Merged, adding a ROS content sharing demo snap and updating the standalone ROS demo to run automatically. Resolves Launchpad bug #1664776 and builds upon PR #1140.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4221 extensions: support for content sharing for ROS snapcraft merged Merged Sept 14, 2023. Adds ROS content sharing support and snapcraft extensions for core20/22 and colcon/catkin. Rebased onto main and PR #4271, then squash-merged after dual approval. One test disabled due to conflicts.
74%
#4828 Add ROS 2 Jazzy content-sharing support snapcraft merged Added ROS 2 Jazzy content-sharing support. Merged after approval by two reviewers and passing CI checks. Changes span 13 files (+627/-18). Author noted unrelated failing spread tests.
73%
#6234 docs(ros): update demo launch file used for jazzy snapcraft merged Merged a documentation fix updating the ROS 2 jazzy app craft tutorial to reference the correct demo launch file. Approved by three reviewers and integrated after passing CI checks.
71%
#6139 fix: ros content sharing non upstream package 8 14 snapcraft merged Merged a fix updating the ROS 2 plugin to handle non-upstream package dependencies and replace deprecated rospack with ros2 pkg. The changes supersede PR #6120, incorporate requested unit tests, and passed review and CI validation.
71%