← Back to issue list

demos: add ROS content sharing demo

View original Github issue

Metadata

Project
snapcraft
Number
#1186
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged in commit 1fb6d756a, adding a ROS content-sharing demo and automating the standalone ROS demo test, completing LP #1664776.

Resolution: closed resolved

Reason: PR #1186 was approved and merged as commit 1fb6d756a. It added the ROS content-sharing demo and updated the standalone ROS demo test.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR finishes off LP: [#1664776](https://bugs.launchpad.net/snapcraft/+bug/1664776) by adding a demo snap for ROS content sharing. It also updates the standalone ROS demo to run the command, removing the need for a manual test. **Note:** This PR builds upon #1140.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in commit 1fb6d756a, adding a ROS content-sharing demo and automating the standalone ROS demo test, completing LP #1664776.
stealth/space-bunny-alpha — closed resolved Merged in #1186 (commit 1fb6d756a), adding a ROS content-sharing demo and automating the standalone ROS demo test. Completed LP #1664776 on top of #1140.
stealth/space-bunny-alpha — closed resolved Merged PR #1186 (commit 1fb6d756a) added a ROS content-sharing demo and automated the standalone ROS demo test, completing LP #1664776.
qwen/qwen3.6-35b-a3b — — Merged changes adding a ROS content sharing demo snap and automating the standalone ROS demo test, resolving Launchpad bug #1664776. Approved by one reviewer, modified 15 files, building upon PR #1140.
qwen3.6-35b-a3b-mtp-q6 — — Merged to close Launchpad bug #1664776 by adding a ROS content sharing demo snap and automating the standalone ROS demo test, building upon PR #1140.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1140 (confidence 99%)

    PR #1186 explicitly built upon the merged Catkin underlay support introduced by #1140.

Related issues

Issue Project State Summary Similarity
#4180 Feature/ros content sharing snapcraft closed Closed unmerged after inactivity; ROS content-sharing support was delivered by merged PR #4221 in commit 374c5c6a6.
75%
#6139 fix: ros content sharing non upstream package 8 14 snapcraft merged Merged in commit 0833c6d21, fixing ROS 2 content sharing for non-upstream dependencies and replacing deprecated rospack with ros2 pkg; supersedes #6120.
72%