← Back to issue list

fix: ros content sharing non upstream package 8 14

View original Github issue

Metadata

Project
snapcraft
Number
#6139
Type
pull request
State
merged
Author
Guillaumebeuzeboc
Labels
PR: Run Manual Spread
Created
Updated
Closed

Current evaluation

Merged in commit 0833c6d21, fixing ROS 2 content sharing for non-upstream dependencies and replacing deprecated rospack with ros2 pkg; supersedes #6120.

Resolution: closed resolved

Reason: PR #6139 was merged as commit 0833c6d21, updating package discovery to include non-upstream ROS packages and use ros2 pkg. It replaced the earlier PR #6120.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The current ROS 2 plugin was not capable of handling ROS 2 packages dependencies from the ROS content sharing not available upstream. Additionally, I realized we've been using `rospack`, a deprecated ROS package instead of `ros2 pkg`. Replacing: https://github.com/canonical/snapcraft/pull/6120 --- - [X] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [X] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [X] I've successfully run `make lint && make test`. - [X] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in commit 0833c6d21, fixing ROS 2 content sharing for non-upstream dependencies and replacing deprecated rospack with ros2 pkg; supersedes #6120.
stealth/space-bunny-alpha — closed resolved Merged PR #6139 fixed ROS 2 content sharing for non-upstream dependencies, replaced deprecated rospack with ros2 pkg, and superseded #6120 (commit 0833c6d21).
stealth/space-bunny-alpha — closed resolved Merged #6139 fixed ROS 2 content sharing for non-upstream dependencies and replaced deprecated rospack with ros2 pkg, superseding #6120.
stealth/space-bunny-alpha — closed resolved Merged PR #6139 fixed ROS 2 content sharing for non-upstream dependencies and replaced deprecated rospack with ros2 pkg, superseding #6120.
qwen/qwen3.6-35b-a3b — — Merged a fix updating the ROS 2 plugin to handle non-upstream package dependencies and replace deprecated rospack with ros2 pkg. The changes supersede PR #6120, incorporate requested unit tests, and passed review and CI validation.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix enabling the ROS 2 plugin to handle non-upstream ROS content sharing dependencies. Replaces deprecated rospack with ros2 pkg, superseding PR #6120. Unit tests were added following reviewer feedback.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#6138 Fix/ros content sharing non upstream package 8 14 snapcraft closed PR #6138 was closed unmerged and superseded by #6139, which fixed ROS 2 content sharing for non-upstream packages and replaced deprecated rospack with ros2 pkg.
91%
#6120 fix(ROS): ROS snap content sharing now supports non upstream packages snapcraft closed PR was approved but closed unmerged; author retargeted the ROS content-sharing fix (non-upstream deps, rospack -> ros2 pkg) to PR #6139, merged as commit 0833c6d21 into hotfix/8.14 for Snapcraft 8.
85%
#4180 Feature/ros content sharing snapcraft closed Closed unmerged after inactivity; ROS content-sharing support was delivered by merged PR #4221 in commit 374c5c6a6.
73%
#1186 demos: add ROS content sharing demo snapcraft merged Merged in commit 1fb6d756a, adding a ROS content-sharing demo and automating the standalone ROS demo test, completing LP #1664776.
72%
#4221 extensions: support for content sharing for ROS snapcraft merged Merged in 374c5c6a6, adding ROS content-sharing support and ROS extensions/plugins for core20/core22 (Noetic, Foxy, and Humble).
71%