fix: ros content sharing non upstream package 8 14
Metadata
Current evaluation
Merged a fix updating the ROS 2 plugin to handle non-upstream package dependencies and replace deprecated rospack with ros2 pkg. The changes supersede PR #6120, incorporate requested unit tests, and passed review and CI validation.
Suggested action: —
No scores available.
Issue body
The current ROS 2 plugin was not capable of handling ROS 2 packages dependencies from the ROS content sharing not available upstream.
Additionally, I realized we've been using `rospack`, a deprecated ROS package instead of `ros2 pkg`.
Replacing: https://github.com/canonical/snapcraft/pull/6120
---
- [X] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [X] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [X] I've successfully run `make lint && make test`.
- [X] I've added or updated any relevant documentation.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix updating the ROS 2 plugin to handle non-upstream package dependencies and replace deprecated rospack with ros2 pkg. The changes supersede PR #6120, incorporate requested unit tests, and passed review and CI validation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix enabling the ROS 2 plugin to handle non-upstream ROS content sharing dependencies. Replaces deprecated rospack with ros2 pkg, superseding PR #6120. Unit tests were added following reviewer feedback. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix enabling the ROS 2 plugin to handle non-upstream ROS content sharing dependencies and replacing deprecated rospack with ros2 pkg. Supersedes PR #6120. Unit tests added per reviewer feedback prior to merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6120 fix(ROS): ROS snap content sharing now supports non upstream packages | snapcraft | closed | Superseded by PR #6139 targeting hotfix/8.14. Fixes ROS 2 plugin to support non-upstream packages and replaces deprecated rospack with ros2 pkg for an immediate release. | |
| #6138 Fix/ros content sharing non upstream package 8 14 | snapcraft | closed | Closed without merging. CI checks failed on conventional commit policy and integration tests. Zero reviewer comments and 113 days of inactivity resulted in the changes being abandoned. | |
| #3536 ROS plugins v2 misc fixes | snapcraft | merged | Merged. Fixes ROS plugins v2 staging failures by checking local ROS directories and skipping rosdep resolution for locally available packages. Updated tests for core20. Approved by two reviewers and passed CI. | |
| #1186 demos: add ROS content sharing demo | snapcraft | merged | Merged changes adding a ROS content sharing demo snap and automating the standalone ROS demo test, resolving Launchpad bug #1664776. Approved by one reviewer, modified 15 files, building upon PR #1140. | |
| #4221 extensions: support for content sharing for ROS | snapcraft | merged | Merged Sept 14, 2023. Adds ROS content sharing support and snapcraft extensions for core20/22 and colcon/catkin. Rebased onto main and PR #4271, then squash-merged after dual approval. One test disabled due to conflicts. | |
| #4828 Add ROS 2 Jazzy content-sharing support | snapcraft | merged | Added ROS 2 Jazzy content-sharing support. Merged after approval by two reviewers and passing CI checks. Changes span 13 files (+627/-18). Author noted unrelated failing spread tests. |