← Back to issue list

store: API interactions for developer collaboration.

View original Github issue

Metadata

Project
snapcraft
Number
#1235
Type
pull request
State
closed
Author
psivaa
Labels
—
Created
Updated
Closed

Current evaluation

PR #1235 (snap-developer store plumbing) was closed unmerged by sergiusens on 2017-04-10 in favor of #1246, which was merged as commit 6ebe7783d with the same collaboration plumbing work; UI later added in #1288.

Resolution: closed superseded

Reason: Maintainer sergiusens closed the PR with the comment "closing in favor of #1246". The successor PR #1246 ('store: plumbing for collaboration support.') was merged as commit 6ebe7783d, delivering the GET/PUT snap-developer assertion plumbing, generalized validate helpers and assertion signing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Carry out the plumbing work for developer collaboration feature (snap_developer) for the UI to be wired in later. - GET/PUT snap-developer assertions - Refactor 'get|put_validate' helpers to generalise the use. - Sign snap-developer assertion using `snap sign` LP: [#1680123](https://bugs.launchpad.net/snapcraft/+bug/1680123)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #1235 (snap-developer store plumbing) was closed unmerged by sergiusens on 2017-04-10 in favor of #1246, which was merged as commit 6ebe7783d with the same collaboration plumbing work; UI later added in #1288.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of #1246, which merged the snap-developer store plumbing as commit 6ebe7783d, including GET/PUT assertions, generalized validation, and signing support.
qwen/qwen3.6-35b-a3b — — Superseded by pull request #1246. The API plumbing and assertion signing changes for developer collaboration were closed in favor of an alternative implementation following review and test adjustments.
qwen3.6-35b-a3b-mtp-q6 — — Implemented API plumbing for developer collaboration assertions and refactored validation helpers. The PR was closed and superseded by #1246 after fixing integration test failures and addressing review comments.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#1246 (confidence 98%)

    Explicitly named in the closing maintainer comment; merged as 6ebe7783d with equivalent scope.

  • Related To: canonical/snapcraft#1288 (confidence 72%)

    Follow-up PR 'store: collaboration UI for snaps' (7f8f43912) wiring the UX that #1235 deliberately left hidden.

Related issues

Issue Project State Summary Similarity
#1246 store: plumbing for collaboration support. snapcraft merged Merged as 6ebe7783d, adding store plumbing for snap-developer collaboration assertions, generalized validation helpers, and assertion signing.
72%
#3692 legacy storeapi: use craft-store snapcraft merged PR #3692 merged into snapcraft/7.0 (merge 5a850ca04, commit 15b55daa8), swapping legacy storeapi's http_clients implementation for craft-store, dropping obsolete tests, adapting callers to API changes, and removing needless logout calls.
70%