← Back to issue list

legacy storeapi: use craft-store

View original Github issue

Metadata

Project
snapcraft
Number
#3692
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

PR #3692 merged into snapcraft/7.0 (merge 5a850ca04, commit 15b55daa8), swapping legacy storeapi's http_clients implementation for craft-store, dropping obsolete tests, adapting callers to API changes, and removing needless logout calls.

Resolution: closed resolved

Reason: The PR was approved and merged by maintainer sergiusens into snapcraft/7.0 (merge commit 5a850ca04 "Merge pull request #3692 from snapcore/craft-store-ng", branch head 15b55daa8 "legacy storeapi: use craft-store"), completing the CRAFT-1023 migration of the legacy store API client onto craft-store.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- Replace the http_clients implementation in storeapi with craft-store. - Remove no longer necessary tests. - Adapt the code base to the slight API changes (with consideration of being entirely replaced as commands migrate out of legacy). - Remove logout calls for when not logged in. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- CRAFT-1023

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #3692 merged into snapcraft/7.0 (merge 5a850ca04, commit 15b55daa8), swapping legacy storeapi's http_clients implementation for craft-store, dropping obsolete tests, adapting callers to API changes, and removing needless logout calls.
stealth/space-bunny-alpha — closed resolved Merged #3692 (commit 15b55daa8), replacing legacy storeapi’s HTTP client with craft-store, removing obsolete tests and unnecessary logout calls, and adapting callers to API changes.
stealth/space-bunny-alpha — closed resolved Merged #3692 (15b55da8, merge 5a850ca04) replaced legacy storeapi HTTP clients with craft-store, adapting APIs, removing obsolete tests, and skipping logout when not logged in.
qwen/qwen3.6-35b-a3b — — Merged PR replaces the legacy storeapi HTTP client with craft-store, removes obsolete tests and logout calls, and adapts the codebase to craft-store API changes. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0. Replaced the legacy storeapi http_clients implementation with craft-store, adapted code for minor API changes, removed obsolete tests, and eliminated unnecessary logout calls.

Update history

No update history recorded yet.

Related work

  • Duplicate Of: canonical/snapcraft#3684 (confidence 90%)

    Earlier PR with the identical title 'legacy storeapi: use craft-store'; closed and superseded by #3692, which merged.

  • Related To: canonical/snapcraft#3880 (confidence 55%)

    Follow-up merged PR (commit 383b844ee) adding a craft-store-derived on-prem base client and updating the legacy JSON decoder mock affected by this change.

Related issues

Issue Project State Summary Similarity
#3684 legacy storeapi: use craft-store snapcraft closed Closed in favor of #3692, which merged the legacy storeapi migration to craft-store as 15b55daa8 (merge 5a850ca04).
87%
#3686 storeapi: export SnapAPI snapcraft merged Exported SnapAPI from storeapi and merged it into snapcraft/7.0 via PR #3686 (merge e5a1886b5, commit 1d7c2c12d), completing CRAFT-1021.
76%
#3794 store: full support for legacy login snapcraft merged Merged PR #3794 via commit 86193a7b4 (7194ef18d), restoring legacy-login compatibility by using existing Snapcraft credentials to build craft-store authorization headers.
76%
#3592 storeapi: auth client for api.snapcraft.io snapcraft closed Merged #3592 at commit 9674a2c, adding the Store API authentication client for api.snapcraft.io.
74%
#3744 cli: enable craft-store logging snapcraft merged Merged PR #3744 (commit 6f7e26e6a) enabled craft-store logging in the Snapcraft CLI; merge commit b5d3e916d.
73%
#806 Remove snapcraft.storeapi.common snapcraft merged PR #806 merged (commit c810dedd) by cjwatson, deleting the unused snapcraft/storeapi/common.py (-192 lines, 5 files) after all callers moved to StoreClient, and dropping the requests-oauthlib dependency.
71%
#565 store: replace implementation with craft-store (CRAFT-491) charmcraft merged Merged #565 into main, replacing Charmcraft's store implementation with craft-store for CRAFT-491 (merge commit 70ba8e28).
70%
#1235 store: API interactions for developer collaboration. snapcraft closed PR #1235 (snap-developer store plumbing) was closed unmerged by sergiusens on 2017-04-10 in favor of #1246, which was merged as commit 6ebe7783d with the same collaboration plumbing work; UI later added in #1288.
70%