← Back to issue list

recording: save the snapcraft.yaml in the resulting snap

View original Github issue

Metadata

Project
snapcraft
Number
#1278
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged. Saves snapcraft.yaml to prime/snap in the resulting snap. Approved by one reviewer with passing CI and 100% diff coverage. Unresolved comments remain, but the implementation is accepted as a starting point.

Suggested action:

No scores available.

Issue body

Record the snapcraft.yaml in prime/snap/snapcraft.yaml. This is missing the annotation, it's just a simple version to get started and discuss the details.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Saves snapcraft.yaml to prime/snap in the resulting snap. Approved by one reviewer with passing CI and 100% diff coverage. Unresolved comments remain, but the implementation is accepted as a starting point.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Saves snapcraft.yaml in the resulting snap's prime/snap directory as a baseline implementation. Maintained 95.33% coverage with 100% diff coverage. Intended as an initial version for further discussion.
qwen3.6-35b-a3b-mtp-q6 Merged. Saves snapcraft.yaml to prime/snap/snapcraft.yaml in the built snap. Initial implementation lacks annotations as a baseline. Diff coverage remained at 100%. An ordered dict import side-effect was noted but accepted.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1407 recording: record the original snapcraft.yaml snapcraft merged Merged to record the original snapcraft.yaml. Approved by one reviewer, modified 6 files with 91 additions and 31 deletions. Author noted the change requires PR #1406.
78%
#2160 many: refactor snapcraft.yaml loading out of load_config snapcraft merged Merged a refactor separating raw snapcraft.yaml loading from validated processing within load_config. Approved by reviewer, passed CI checks, and integrated into master with 95.54% diff coverage.
72%
#4 snap: introduce initial snap packaging (CRAFT-578) rockcraft merged Merged initial snap packaging implementation (CRAFT-578). Approved by one reviewer, passed CI checks, and added 86 lines across three files.
71%
#146 Syntax of snapcraft.yaml (1.x) snapcraft merged Merged after rebasing to resolve diff conflicts and squashing commits. The pull request updates snapcraft.yaml (1.x) syntax and received final approval before integration.
71%
#2411 cli: snapcraft init with a base snapcraft merged Merged. Adds a syntax documentation link after snapcraft init execution. Approved by one reviewer, passed CI checks, modified five files, and achieved 100% diff coverage. Resolves LP #1803776.
70%
#1073 project: snapcraft.yaml in a snap directory snapcraft merged Merged into master. Defaults new projects to place snapcraft.yaml inside a snap directory while retaining support for legacy locations. Approved and passed CI checks.
70%