recording: record build-snaps installed during the pull
Metadata
Current evaluation
Merged as e1d74020b, recording build-snaps installed during the pull and implementing canonical/snapcraft#1556.
Resolution: closed resolved
Reason: PR #1566 was merged with commit e1d74020b, adding recording of build-snaps installed during the pull and resolving the linked tracking work in #1556.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updates: #1556
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as e1d74020b, recording build-snaps installed during the pull and implementing canonical/snapcraft#1556. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1566 (commit e1d74020b) records build-snaps installed during the pull, implementing the change tracked by #1556; approved by two reviewers. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1566 records build-snaps installed during the pull, implementing #1556. Approved by two reviewers; the fake-snapd follow-up was proposed in #1569. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to record build-snaps installed during the pull step, addressing #1556. Approved by two reviewers with a +74/-8 line change across eight files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to record build-snaps installed during the pull step, resolving #1556. Updates align with snapd fake merge proposals in #1569. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#1556
(confidence 100%)
The PR explicitly states that it updates this build-snaps recording issue.
-
Related To:
canonical/snapcraft#1569
(confidence 95%)
The maintainer linked this merged fake-snapd refactoring work as a follow-up.
-
Related To:
canonical/snapcraft#1567
(confidence 90%)
Companion merged PR for recording snaps installed on the machine, building on #1566.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1556 build-snaps recording | snapcraft | closed | Build-snaps recording was implemented and merged in canonical/snapcraft#1566 via commit e1d74020b. | |
| #1295 recording: record build packages installed in the snap | snapcraft | merged | Merged PR #1295 as commit 9a475ba5d, adding recording of build packages installed in the snap. | |
| #1567 recording: record the snaps installed on the machine | snapcraft | merged | Merged host-installed snap recording in commit 45131df2a, building on #1566; fake-snapd test refactoring continued in #1569. | |
| #1293 recording: record stage packages installed in the snap | snapcraft | merged | Merged PR #1293 as commit 9b3f7a05b, adding recording of stage packages installed in the snap after prerequisite #1292. | |
| #1518 project: introduce build-snaps | snapcraft | merged | Merged PR #1518 as commit 69dceb848, adding a project-level and part-level `build-snaps` keyword with advanced grammar support (+902/-10, 24 files). Implements the design in snapcraft#1442; the feature remains in current snapcraft. | |
| #1340 state: save all the build packages as global | snapcraft | merged | Merged in canonical/snapcraft#1340 (51401fc07), recording build packages globally at install time instead of capturing their versions per part. | |
| #1407 recording: record the original snapcraft.yaml | snapcraft | merged | Merged PR #1407 as c528e6729, adding recording of the original snapcraft.yaml after prerequisite #1406 renamed the recording file to manifest.yaml. | |
| #1688151 snapcraft pull doesn't save the installed build dependencies | snapcraft (launchpad) | closed | Fixed in merged PR #1299 (95d737dc3); PR #1340 later expanded recording to all build packages globally. | |
| #1278 recording: save the snapcraft.yaml in the resulting snap | snapcraft | merged | Merged PR #1278 in commit 463f1e8fd, adding snapcraft.yaml to prime/snap so the build definition is saved in the resulting snap. | |
| #1442 `build-snaps` | snapcraft | closed | Implemented build-snaps in merged PR canonical/snapcraft#1518 (commit 69dceb848), adding project- and part-level keys with advanced grammar support. |