← Back to issue list

cleanbuild: set the container language to C.UTF-8

View original Github issue

Metadata

Project
snapcraft
Number
#1304
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1304 (commit 56004496c) makes cleanbuild set the container locale to C.UTF-8, fixing Launchpad bug #1662456; follow-up #1310 applied C.UTF-8 to the docker test locale.

Resolution: closed resolved

Reason: The PR was merged into master as commit 56004496c, setting the cleanbuild container language/locale to C.UTF-8 after review feedback to use C.UTF-8 over en_US.UTF-8; the related desktop-file encoding bug (LP #1662456) was fully addressed by the companion PR #1309 (commit e5751c733).

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: [#1662456](https://bugs.launchpad.net/snapcraft/+bug/1662456)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1304 (commit 56004496c) makes cleanbuild set the container locale to C.UTF-8, fixing Launchpad bug #1662456; follow-up #1310 applied C.UTF-8 to the docker test locale.
stealth/space-bunny-alpha — closed resolved Merged PR #1304 in commit 56004496c, setting cleanbuild containers to C.UTF-8 and addressing Launchpad bug #1662456.
qwen/qwen3.6-35b-a3b — — Merged PR sets the cleanbuild container locale to C.UTF-8, replacing en_*.UTF-8 to ensure consistent availability. The change addresses Launchpad bug #1662456 and incorporates reviewer feedback for reliability.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Changed cleanbuild container locale to C.UTF-8 for guaranteed availability. Added a unit test to verify the setting. Resolved review feedback and deferred integration testing to a related PR.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1309 (confidence 90%)

    Companion PR (commit e5751c733) reading/writing desktop files as utf-8, resolving LP #1662456.

  • Related To: snapcraft#1310 (confidence 75%)

    Commit 45acbf0be uses C.UTF-8 for the docker test locale, extending the same change.

Related issues

Issue Project State Summary Similarity
#1310 tests: use C.UTF-8 for the docker locale snapcraft merged Merged #1310 (commit 45acbf0be), changing Docker test locale settings to C.UTF-8; coverage remained unchanged.
70%