← Back to issue list

meta: read and write the desktop file with utf-8 encoding

View original Github issue

Metadata

Project
snapcraft
Number
#1309
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged in snapcraft#1309 via commit e5751c733, fixing UTF-8 handling when reading and writing desktop files and adding integration coverage for LP #1662456.

Resolution: closed resolved

Reason: PR #1309 was approved and merged as commit e5751c733. The change explicitly uses UTF-8 for desktop-file I/O and adds an integration test.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: [#1662456](https://bugs.launchpad.net/snapcraft/+bug/1662456)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#1309 via commit e5751c733, fixing UTF-8 handling when reading and writing desktop files and adding integration coverage for LP #1662456.
stealth/space-bunny-alpha — closed resolved Merged PR #1309 (commit e5751c733) fixed UTF-8 handling when reading and writing desktop files, resolving LP #1662456; an integration test was added.
qwen/qwen3.6-35b-a3b — — Merged, resolving UTF-8 encoding issues when reading and writing desktop files (LP #1662456). Approved by two reviewers with 100% diff coverage. Adds an integration test and updates five files to fix the bug.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Fixes desktop file read/write to use UTF-8 encoding, resolving Launchpad bug #1662456. Added an integration test for verification, achieving 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2722 meta: fixes for desktop file handling snapcraft merged Merged in snapcraft PR #2722 via dac7a776c and 81d13ed06, fixing multi-section desktop files and preserving arguments in Exec=.
72%
#1662456 snapcraft fails if desktop file included "ascii" cannot decode byte snapcraft (launchpad) closed Fixed by snapcraft PRs #1304 and #1309: cleanbuild containers use C.UTF-8, and desktop files are explicitly read and written as UTF-8.
72%