← Back to issue list

kernel plugin: config check: remove DMIID option

View original Github issue

Metadata

Project
snapcraft
Number
#1319
Type
pull request
State
merged
Author
piso77
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1319 as 1dc35f17e, removing the kernel plugin’s DMIID warning so non-EFI targets such as armhf no longer receive a false warning.

Resolution: closed resolved

Reason: The approved change was merged into master as commit 1dc35f17e, removing CONFIG_DMIID from the kernel plugin’s config check for targets without EFI support.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The DMIID config option is only present if a DMI EFI table is present, and since some ubuntu core targets (e.g. armhf) don't support EFI, it's better to stop warning about its absence. Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> LP: #1691116

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1319 as 1dc35f17e, removing the kernel plugin’s DMIID warning so non-EFI targets such as armhf no longer receive a false warning.
stealth/space-bunny-alpha — closed resolved Merged #1319 (commit 1dc35f17e) removed the kernel plugin’s DMIID config warning, avoiding false warnings on non-EFI targets such as armhf.
qwen/qwen3.6-35b-a3b — — Merged removal of the DMIID config check in the kernel plugin. The check triggered false warnings on non-EFI architectures like armhf. Approved by one reviewer with no coverage impact.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Removed the DMIID config check from the kernel plugin to prevent warnings on Ubuntu Core targets without EFI support, resolving LP: #1691116.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#1691116 kernel: config check: remove DMIID option snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#1319, commit 1dc35f17e ("kernel plugin: do not warn about DMIID in config check"). The kernel plugin stopped warning when CONFIG_DMIID is absent, since non-EFI targets like armhf lack it. Maintainer closed the LP bug pointing at that PR.
87%
#1223 kernel plugin: check_config() and check_initrd() support snapcraft merged Merged kernel-plugin checks that parse .config and initrd module lists, reporting missing mandatory options or boot-required code; landed in commit fda091f50.
71%