← Back to issue list

kernel plugin: config check: remove DMIID option

View original Github issue

Metadata

Project
snapcraft
Number
#1319
Type
pull request
State
merged
Author
piso77
Labels
Created
Updated
Closed

Current evaluation

Merged removal of the DMIID config check in the kernel plugin. The check triggered false warnings on non-EFI architectures like armhf. Approved by one reviewer with no coverage impact.

Suggested action:

No scores available.

Issue body

The DMIID config option is only present if a DMI EFI table is present, and since some ubuntu core targets (e.g. armhf) don't support EFI, it's better to stop warning about its absence. Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> LP: #1691116

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged removal of the DMIID config check in the kernel plugin. The check triggered false warnings on non-EFI architectures like armhf. Approved by one reviewer with no coverage impact.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Removed the DMIID config check from the kernel plugin to prevent warnings on Ubuntu Core targets without EFI support, resolving LP: #1691116.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Removed the DMIID config check from the kernel plugin to eliminate false warnings on non-EFI targets like armhf Ubuntu Core. Code coverage unchanged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1691116 kernel: config check: remove DMIID option snapcraft (launchpad) closed Fixed by removing the DMIID kernel config check to prevent warnings on non-EFI Ubuntu Core targets like armhf. The issue was closed after the configuration validation was updated.
83%
#1223 kernel plugin: check_config() and check_initrd() support snapcraft merged Merged implementation of check_config() and check_initrd() for the kernel plugin. The update parses .config and initrd files to verify mandatory kernel options and boot code are present. Minor test coverage decrease was accepted.
76%
#1303 kernel plugin: slightly improve the messaging of check_config() snapcraft merged Merged into master. Updates kernel plugin check_config() messaging to specify applicable kernel versions for configuration options. Non-functional text improvement approved by reviewer and integrated with full diff coverage.
73%
#4116 plugins: kernel: remove use of deprecated config.common.ports config snapcraft merged Merged removal of deprecated config.common.ports usage from the Ubuntu kernel plugin to prevent future build failures. Approved by reviewers, passed CI, and modified 3 files.
72%
#3998 Kernel plugin: multiple fixes snapcraft merged Merged multiple kernel plugin fixes addressing a regression, a crash when no kernel modules are defined, documentation updates, and initramfs overlay warnings. Approved by one reviewer and passed CI checks.
71%
#1689564 kernel plugin: check_config(): improve the messaging for some CONFIG_* option snapcraft (launchpad) closed Updated check_config() messaging to specify kernel version constraints for CONFIG_* options. The non-functional text improvement was merged.
70%