← Back to issue list

kernel plugin: check_config() and check_initrd() support

View original Github issue

Metadata

Project
snapcraft
Number
#1223
Type
pull request
State
merged
Author
piso77
Labels
Created
Updated
Closed

Current evaluation

Merged implementation of check_config() and check_initrd() for the kernel plugin. The update parses .config and initrd files to verify mandatory kernel options and boot code are present. Minor test coverage decrease was accepted.

Suggested action:

No scores available.

Issue body

Make snapcraft smarter by parsing .config and initrd modules list and printing out if there are mandatory options missing, or if a boot required piece of code is not builtin or part packaged into initrd Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com> LP: #1676806

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged implementation of check_config() and check_initrd() for the kernel plugin. The update parses .config and initrd files to verify mandatory kernel options and boot code are present. Minor test coverage decrease was accepted.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Introduces check_config() and check_initrd() to the kernel plugin for validating mandatory kernel options and initrd modules. Accepted following minor file placement discussion and code review, with a negligible coverage decrease.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Adds check_config() and check_initrd() to the kernel plugin to validate mandatory kernel options and initrd modules. Code placed in kbuild.py following maintainer review, with minor coverage decrease noted.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1303 kernel plugin: slightly improve the messaging of check_config() snapcraft merged Merged into master. Updates kernel plugin check_config() messaging to specify applicable kernel versions for configuration options. Non-functional text improvement approved by reviewer and integrated with full diff coverage.
81%
#1689564 kernel plugin: check_config(): improve the messaging for some CONFIG_* option snapcraft (launchpad) closed Updated check_config() messaging to specify kernel version constraints for CONFIG_* options. The non-functional text improvement was merged.
79%
#1319 kernel plugin: config check: remove DMIID option snapcraft merged Merged removal of the DMIID config check in the kernel plugin. The check triggered false warnings on non-EFI architectures like armhf. Approved by one reviewer with no coverage impact.
76%
#6255 Feature/kernel initrd plugin merge snapcraft merged Merged after resolving conflicts and aligning with HEAD. Integrates kernel initrd plugin support, requires PR #6254, approved by two reviewers, and passed CI checks.
74%
#476 kernel plugin: iterate over modules to add to initrd snapcraft merged Merged updates to the kernel plugin that iterate over modules for initrd inclusion. Approved by @kyrofa following successful tests. Resolves LP #1572118 with 36 additions and 6 deletions across two files.
73%
#3998 Kernel plugin: multiple fixes snapcraft merged Merged multiple kernel plugin fixes addressing a regression, a crash when no kernel modules are defined, documentation updates, and initramfs overlay warnings. Approved by one reviewer and passed CI checks.
73%
#463 Kernel plugin: Support lzma/xz-compressed initrd. snapcraft merged Merged to add lzma/xz-compressed initrd support to the kernel plugin. Replaces the file command with the magic library and includes tests. Resolves Launchpad bug 1569337. Approved with minor concerns and merged despite six unresolved review comments.
72%
#6254 feat(kernel,initrd): extend plugins with new options, stabilize snapcraft merged Merged after approval. Extended the kernel plugin with new options, stabilized the initrd plugin, improved documentation, and added tests. Resolved a temporary Resolute tarball naming divergence. Core CI checks passed.
72%
#4057 Kernel plugin: reapplying missed fixes snapcraft merged Merged after applying missed kernel plugin fixes: crash prevention, docs, warnings, and Ubuntu Core 20 initramfs improvements. Approved, passed CI, and merged with updated unit tests.
71%
#4081 Kernel plugin improvements 1 snapcraft merged Merged after approval. The update reorganizes kernel plugin code by moving implementations to a common module and improves readability with textwrap.dedent. Changes affect 5 files, resulting in a net reduction of 259 lines.
71%