← Back to issue list

cli: do not duplicate errors

View original Github issue

Metadata

Project
snapcraft
Number
#1347
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged a fix preventing duplicate CLI error output caused by removing sys.exit in load_config. The PR refactors error handling to prevent recurrence, received approval, and successfully resolves the issue.

Suggested action:

No scores available.

Issue body

The removal of sys.exit when doing `load_config` had a side effect of printing errors twice. The work here does a bit of cleanup so this mistake does not happen again. LP: #1686557 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix preventing duplicate CLI error output caused by removing sys.exit in load_config. The PR refactors error handling to prevent recurrence, received approval, and successfully resolves the issue.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for duplicate CLI error output caused by removing sys.exit in load_config. The refactor cleans up error handling to prevent recurrence. Approved by reviewer and merged.
qwen3.6-35b-a3b-mtp-q6 Merged to fix duplicate CLI error messages triggered by removing sys.exit during config loading. The code cleanup prevents future duplication and was approved by @come-maiz.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1436 cli: properly handle exceptions snapcraft merged Merged a global exception handler for CLI errors, superseding PR #1429. Replaced per-command decorators to simplify maintenance and auto-coverage. Fixed exit_code property test failures before merge.
74%