cli: cleanup error handling
Metadata
Current evaluation
Merged PR #3125 in commit 68c64253b, simplifying CLI error handling with inline typing and removing obsolete Ubuntu 16.04 compatibility logic.
Resolution: closed resolved
Reason: PR #3125 was approved and merged as commit 68c64253b, completing the CLI error-handling cleanup.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- Use inline typing (removing the need for noqa hints)
- Get rid of try/except clause considering 16.04 as we only care about
the snap now.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3125 in commit 68c64253b, simplifying CLI error handling with inline typing and removing obsolete Ubuntu 16.04 compatibility logic. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3125 as 68c64253b, simplifying CLI error handling with inline type annotations and removal of obsolete Ubuntu 16.04 compatibility handling. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3125 via commit 68c64253b, simplifying CLI error handling with inline type annotations and removing obsolete Ubuntu 16.04 compatibility logic. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 68c64253b: simplified CLI error handling with inline typing and removed obsolete 16.04 compatibility handling. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3125 (commit 68c64253b) cleaned up CLI error handling by adopting inline typing and removing obsolete 16.04 compatibility handling. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged CLI error handling cleanup. Removed legacy try/except block for Ubuntu 16.04 and switched to inline type hints to eliminate noqa comments. Approved by reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cleanup of CLI error handling. Replaced external type imports with inline annotations to eliminate noqa directives. Removed obsolete try/except blocks for Ubuntu 16.04, as legacy support is no longer required. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1347 cli: do not duplicate errors | snapcraft | merged | Merged as commit 9e8e336de, PR #1347 eliminated duplicate CLI validation errors and refactored error handling to prevent recurrence. | |
| #1790 cli: include consistent commands to fix error conditions | snapcraft | merged | Merged PR #1790 at b78dbda8, standardizing corrective commands in CLI error messages and closing #1733; prerequisite #1640 added richer common-error guidance. | |
| #1640 cli: add what, why, and how to fix to the common errors | snapcraft | merged | Merged PR #1640 (c1200d9ee) added explanations and corrective guidance to common CLI errors across 15 files. |