← Back to issue list

Added a test to check that the snapcraft files are ignored.

View original Github issue

Metadata

Project
snapcraft
Number
#137
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged a test verifying snapcraft files are excluded from the build directory, alongside minor base plugin test cleanup. Approved by @kyrofa. Changes span one file with +31/-13 lines.

Suggested action:

No scores available.

Issue body

Added a test to check that the snapcraft files are not copied to the build dir. A little cleanup in the rest of the base plugin tests.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a test verifying snapcraft files are excluded from the build directory, alongside minor base plugin test cleanup. Approved by @kyrofa. Changes span one file with +31/-13 lines.
qwen3.6-35b-a3b-mtp-q6 Merged changes adding a test to verify snapcraft files are excluded from the build directory, alongside minor base plugin test cleanup. Approved by @kyrofa.
qwen3.6-35b-a3b-mtp-q6 Merged test verifying snapcraft files are excluded from the build directory, alongside minor base plugin test cleanup. Approved by @kyrofa.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#133 Added a test to check that the snapcraft files are ignored. snapcraft closed Closed after adding a test to verify snapcraft files are excluded from the build directory, alongside minor cleanup in base plugin tests. No review or CI activity was recorded.
86%
#1948 tests: move test files out of the snapcraft dir snapcraft merged Merged reorganization of the test suite, moving test files out of the snapcraft directory. Approved by one reviewer, the change touched 788 files with 615 additions and 589 deletions.
75%
#617 snapcraft update if there is no cache snapcraft merged Merged following maintainer approval. The change ensures snapcraft updates when no cache exists, removing unnecessary test code. Approved by kyrofa with 17 additions and 26 deletions across 12 files.
75%
#50 test: test the snapcraft actions craft-actions merged Merged adding tests for snapcraft actions, mirroring charmcraft tests. Approved by two reviewers with all CI checks passing. Updates two files with 89 additions and 1 deletion.
72%
#4662 fix(test): do not create 2 snapcraft.yaml and confuse location snapcraft merged Merged a test fix preventing duplicate snapcraft.yaml creation in conflicting root and snap directories. Resolves silent overrides and ensures hooks are detected by clarifying fixture paths. Approved and merged.
72%
#1652 tests: fork skip into snaps_tests snapcraft merged Merged changes that forked skip into snaps_tests to prevent overly broad imports in snapcraft.tests from breaking autopackage tests. Approved by two reviewers, passed CI, and modified three files.
71%
#204 Update snapcraft.yaml charmcraft merged Merged updates to snapcraft.yaml by markshuttle. Applied text changes for snapcraft.io and snap users, approved by two reviewers with zero unresolved comments. Diff added 18 lines and removed 14 across one file.
71%
#1407 recording: record the original snapcraft.yaml snapcraft merged Merged to record the original snapcraft.yaml. Approved by one reviewer, modified 6 files with 91 additions and 31 deletions. Author noted the change requires PR #1406.
71%
#299 fix(remote-build): minor edge cases found with snapcraft craft-application merged Fixed minor snapcraft edge cases in remote builds. Merged following approval by two reviewers and passing CI checks. The update modifies three files, adding 43 lines and removing 13.
71%
#85 test: cleanup test now that we have a new enough snapcraft snapcraft-rocks merged Merged test cleanup after upgrading to a stable snapcraft version. Removes six lines of outdated test code. Approved by one reviewer, passed all CI checks, and successfully merged.
70%