← Back to issue list

Added a test to check that the snapcraft files are ignored.

View original Github issue

Metadata

Project
snapcraft
Number
#137
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged into snapcraft via commit cee6740b3, adding regression coverage that Snapcraft files are excluded from build directories and cleaning up base-plugin tests.

Resolution: closed resolved

Reason: PR #137 was merged as commit cee6740b3. The merged change verifies that Snapcraft project files are not copied into the build directory.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Added a test to check that the snapcraft files are not copied to the build dir. A little cleanup in the rest of the base plugin tests.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into snapcraft via commit cee6740b3, adding regression coverage that Snapcraft files are excluded from build directories and cleaning up base-plugin tests.
stealth/space-bunny-alpha — closed resolved Merged PR #137 in commit cee6740b3, adding a regression test ensuring Snapcraft files are excluded from the build directory and cleaning up base-plugin tests.
stealth/space-bunny-alpha — closed resolved Merged PR #137, adding a regression test that snapcraft files are excluded from the build directory and cleaning up base plugin tests.
qwen/qwen3.6-35b-a3b — — Merged a test verifying snapcraft files are excluded from the build directory, alongside minor base plugin test cleanup. Approved by @kyrofa. Changes span one file with +31/-13 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes adding a test to verify snapcraft files are excluded from the build directory, alongside minor base plugin test cleanup. Approved by @kyrofa.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#133 Added a test to check that the snapcraft files are ignored. snapcraft closed Superseded by merged PR canonical/snapcraft#137, which added the Snapcraft-file exclusion regression test and cleaned up base-plugin tests.
89%
#1849 tests: add snap not found tests snapcraft merged Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e.
74%
#4755 tests: fix devel base snap test snapcraft merged Merged #4755, fixing the devel-base integration test to verify Snapcraft can create the base snap and that the resulting devel base is usable.
72%
#4672 Enable Snapcraft plugins in craft-application codepath snapcraft merged Merged PR #4672 (commit 06c842e0b), registering Snapcraft plugins in the craft-application/core24 path and exposing confinement and base lifecycle variables.
70%