Added a test to check that the snapcraft files are ignored.
Metadata
Current evaluation
Superseded by merged PR canonical/snapcraft#137, which added the Snapcraft-file exclusion regression test and cleaned up base-plugin tests.
Resolution: closed superseded
Reason: PR #133 was replaced by the identical work in canonical/snapcraft#137. That PR merged as commit cee6740b3, with the underlying change committed as e25095cae.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Added a test to check that the snapcraft files are not copied to the build dir.
A little cleanup in the rest of the base plugin tests.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Superseded by merged PR canonical/snapcraft#137, which added the Snapcraft-file exclusion regression test and cleaned up base-plugin tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #137, adding a regression test that snapcraft files are excluded from the build directory and cleaning up base plugin tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed after adding a test to verify snapcraft files are excluded from the build directory, alongside minor cleanup in base plugin tests. No review or CI activity was recorded. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes adding a test to verify snapcraft files are not copied to the build directory, alongside cleanup of base plugin tests. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#137
(confidence 98%)
The same test and cleanup were merged through PR #137 in commit cee6740b3.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #137 Added a test to check that the snapcraft files are ignored. | snapcraft | merged | Merged into snapcraft via commit cee6740b3, adding regression coverage that Snapcraft files are excluded from build directories and cleaning up base-plugin tests. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e. | |
| #1194 tests: remove repo.Ubuntu patch for plugins | snapcraft | merged | Merged in PR #1194 (commit 8d7b0ec63), removing obsolete plugin repo.Ubuntu test patches after stage-packages handling moved into Snapcraft core. | |
| #123 tests: remove snapcraft:core | craft-providers | merged | Merged PR #123 (commit 0cffc84, merged in ba78ce4) deleted the obsolete `snapcraft:core` integration test entry and added `snapcraft:devel`, since Multipass removed the core image. | |
| #1651903 Plugin tests need to be reorganized | snapcraft (launchpad) | closed | Fixed: plugin unit tests moved out of the monolithic tests dir into a dedicated subdirectory by merged PR snapcore/snapcraft#1014 (commit d97c00e8f), resolving LP bug #1651903. | |
| #2353 tests: remove dependency on snapcraft for integration tests | snapcraft | merged | PR #2353 by sergiusens merged as commit 6a7c860c4, dropping snapcraft imports from integration tests (27 files, +956/-733) so the suite no longer depends on snapcraft and tests stay independent, alongside the bases/multipass cleanup. |