← Back to issue list

pluginhandler: check for collisions only in existing files

View original Github issue

Metadata

Project
snapcraft
Number
#1405
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged to resolve Launchpad bug #1660696 by updating the pluginhandler to check for collisions only in existing files. Approved by two reviewers, the change modifies six files with 45 additions and 4 deletions.

Suggested action:

No scores available.

Issue body

LP: [#1660696](https://bugs.launchpad.net/snapcraft/+bug/1660696)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to resolve Launchpad bug #1660696 by updating the pluginhandler to check for collisions only in existing files. Approved by two reviewers, the change modifies six files with 45 additions and 4 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged a fix updating pluginhandler to validate collisions only against existing files, resolving Launchpad bug #1660696. This prevents false positives by skipping collision checks for non-existent targets.
qwen3.6-35b-a3b-mtp-q6 Merged to resolve Launchpad bug #1660696 by updating the pluginhandler to check file collisions only against existing files, preventing false positives during packaging.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2117 pluginhandler: correctly dedent the run script snapcraft merged Merged fix to correctly dedent the pluginhandler run script. Passes CI checks and serves as prework for improved error output, partially addressing Launchpad bug #1767625.
74%
#2450 pluginhandler: handle removal of inconsistent files snapcraft merged Merged a fix that prevents crashes during part cleanup when manually removed files are encountered. The system now safely ignores missing files and issues a warning instead. Approved by reviewers and passed CI checks.
73%
#2330 pluginhandler: remove big solidus workaround snapcraft merged Merged removal of the forward slash workaround in pluginhandler, now that bases eliminate wiki parts and allow forbidding slashes in part names. Approved by one reviewer, passed CI, and achieved 100% diff coverage across seven files. Resolves LP #1796723.
71%
#838 pluginhandler: take the file encoding into account. snapcraft merged Merged update to pluginhandler that accounts for file encoding, resolving LP #1628457. Approved by one reviewer with no unresolved comments. Changes span two files with 14 additions and 3 deletions.
70%
#1064 pluginhandler: collide with directories and symlinks snapcraft merged Merged to extend Snapcraft's collision detection to directories and symlinks, resolving bug LP: #1658225. The pull request was updated and re-opened to address dependencies and test failures before final approval and merge.
70%