pluginhandler: collide with directories and symlinks
Metadata
Current evaluation
Merged #1064 via commit d4b104887, adding directories and symlinks to pluginhandler collision detection, including conflicting symlink targets; fixes LP #1658225.
Resolution: closed resolved
Reason: PR #1064 was merged as commit d4b104887 after being updated for the revised organize handling, resolving the reported collision gaps.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Snapcraft's collision detection currently only checks files. This PR fixes LP: [#1658225](https://bugs.launchpad.net/snapcraft/+bug/1658225) by adding directories and symlinks to the list, making sure to catch files that collide with directories, and symlinks that point to different places.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1064 via commit d4b104887, adding directories and symlinks to pluginhandler collision detection, including conflicting symlink targets; fixes LP #1658225. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #1064 via commit d4b104887, extending pluginhandler collision checks from files to directories and symlinks, including conflicting symlink targets. Resolves LP #1658225. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1064 in d4b104887, extending pluginhandler collision checks to directories and symlinks and fixing LP #1658225. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to extend Snapcraft's collision detection to directories and symlinks, resolving bug LP: #1658225. The pull request was updated and re-opened to address dependencies and test failures before final approval and merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after 2018 updates. Extends Snapcraft collision detection to directories and symlinks, resolving bug LP#1658225. Initially delayed by PR #897. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#897
(confidence 90%)
Its organize redesign initially blocked #1064 but was later handled differently.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3406 pluginhandler: do not walk symlinks for include filesets | snapcraft | merged | Merged #3406 as commit 63c2c7a7f, adding a symlink check before include-fileset traversal so external links no longer bypass filtering of target directories. | |
| #1405 pluginhandler: check for collisions only in existing files | snapcraft | merged | Collision detection was fixed to consider only existing files, resolving LP #1660696; PR #1405 was merged as commit dbdc4b5a6. | |
| #2628 pluginhandler: honour symlink directory paths for filesets (LP: #1833408) | snapcraft | merged | Merged as 3f5799a72, making filesets honor symlink directory paths and fixing LP #1833408; regression tests were added and faulty tests corrected. |