pluginhandler: collide with directories and symlinks
Metadata
Current evaluation
Merged to extend Snapcraft's collision detection to directories and symlinks, resolving bug LP: #1658225. The pull request was updated and re-opened to address dependencies and test failures before final approval and merge.
Suggested action: —
No scores available.
Issue body
Snapcraft's collision detection currently only checks files. This PR fixes LP: [#1658225](https://bugs.launchpad.net/snapcraft/+bug/1658225) by adding directories and symlinks to the list, making sure to catch files that collide with directories, and symlinks that point to different places.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to extend Snapcraft's collision detection to directories and symlinks, resolving bug LP: #1658225. The pull request was updated and re-opened to address dependencies and test failures before final approval and merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after 2018 updates. Extends Snapcraft collision detection to directories and symlinks, resolving bug LP#1658225. Initially delayed by PR #897. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after rebasing and resolving dependencies. Updates collision detection to include directories and symlinks, fixing Launchpad bug #1658225. Integration increased coverage by less than 0.01%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3406 pluginhandler: do not walk symlinks for include filesets | snapcraft | merged | Merged fix prevents snapcraft from incorrectly traversing symlinks during include fileset generation. Checks targets before walking to resolve filtering issues for symlinked directories. Approved, passed CI, and merged. | |
| #1405 pluginhandler: check for collisions only in existing files | snapcraft | merged | Merged to resolve Launchpad bug #1660696 by updating the pluginhandler to check for collisions only in existing files. Approved by two reviewers, the change modifies six files with 45 additions and 4 deletions. |