← Back to issue list

cli: clean cmd migrated to docopts.

View original Github issue

Metadata

Project
snapcraft
Number
#143
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR canonical/snapcraft#143 (commit c947ec280) migrated the clean CLI command to docopts and moved load_config into the yaml module, after positive review from kyrofa and come-maiz.

Resolution: closed resolved

Reason: The PR itself was merged into snapcraft as commit c947ec280 "cli: clean cmd migrated to docopts.", landing the docopts-based clean command plus the load_config relocation to the yaml module. It supersedes the earlier, closed attempt canonical/snapcraft#142 for the same migration.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This also involved moving `load_config` to the `yaml` module. Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR canonical/snapcraft#143 (commit c947ec280) migrated the clean CLI command to docopts and moved load_config into the yaml module, after positive review from kyrofa and come-maiz.
stealth/space-bunny-alpha — closed resolved Merged PR #143 (commit c947ec280) migrated the clean CLI command to docopts and moved load_config into the yaml module.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#143 via commit c947ec280, migrating clean to docopts and moving load_config into the yaml module.
qwen/qwen3.6-35b-a3b — — Merged. The clean CLI command was migrated to docopts and load_config moved to the yaml module. Reviewers approved the reorganization, deferring one minor comment for future error handling updates.
qwen3.6-35b-a3b-mtp-q6 — — Merged. The clean command was migrated to docopts, and load_config was relocated to the yaml module. Reviewers approved the reorganization, deferring minor comments to a future refactor.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#142 (confidence 88%)

    Earlier closed PR "cli: clean migrated to docopts" for the same migration; #143 landed the work instead.

  • Related To: canonical/snapcraft#151 (confidence 70%)

    Part of the same docopts migration series (strip, #145 pull, #135/#136 help, #160 snap).

Related issues

Issue Project State Summary Similarity
#142 cli: clean migrated to docopts snapcraft closed Closed unmerged and superseded by canonical/snapcraft#143, which landed the clean-command docopts migration in commit c947ec280.
81%
#144 cli: init cmd migrated to docopts. snapcraft merged PR #144 by sergiusens merged the `snapcraft init` CLI command onto the docopts-based command framework (commit 2ed68dde2, 4 files, +104/-63), part of the incremental docopts migration series.
74%
#151 cli: strip command migrated to docopts snapcraft merged Merged PR #151, migrating Snapcraft's strip CLI command to docopts in commit 6251b86f3 across six files.
74%
#135 cli: Move to docopt, help cmd migrated. snapcraft closed Closed unmerged and superseded by canonical/snapcraft#136, which landed the same docopt help-command migration in commit 00642d304. Review feedback was addressed there; tests stayed disabled pending the wider CLI migration.
73%