← Back to issue list

cli: strip command migrated to docopts

View original Github issue

Metadata

Project
snapcraft
Number
#151
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #151, migrating Snapcraft's strip CLI command to docopts in commit 6251b86f3 across six files.

Resolution: closed resolved

Reason: Snapcraft PR #151 was merged as commit 6251b86f3, completing the strip-command docopts migration. A maintainer commented "lgtm" while noting one test lacked assertions.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #151, migrating Snapcraft's strip CLI command to docopts in commit 6251b86f3 across six files.
stealth/space-bunny-alpha — closed resolved Merged commit 6251b86f3 migrated Snapcraft's strip CLI command to docopts across 6 files (+242/-13); the reviewer approved it except for a test without assertions.
qwen/qwen3.6-35b-a3b — — Merged the CLI strip command migration to docopts. Updated 6 files with 242 additions and 13 deletions. Approved by @come-maiz despite a minor note about a test lacking assertions.
qwen3.6-35b-a3b-mtp-q6 — — Merged. The change migrates the CLI strip command to docopts and received approval with a minor note about a test lacking assertions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#144 cli: init cmd migrated to docopts. snapcraft merged PR #144 by sergiusens merged the `snapcraft init` CLI command onto the docopts-based command framework (commit 2ed68dde2, 4 files, +104/-63), part of the incremental docopts migration series.
76%
#142 cli: clean migrated to docopts snapcraft closed Closed unmerged and superseded by canonical/snapcraft#143, which landed the clean-command docopts migration in commit c947ec280.
76%
#145 cli: pull command migrated to docopts snapcraft merged Merged the pull CLI command's migration to docopts in commit 7f09faa72 after incorporating reviewer feedback.
74%
#160 cli: snap command migrated to docopts snapcraft merged Merged the snap command's docopts migration in commit 3331c627c; directory-snap integration testing was explicitly deferred.
74%
#143 cli: clean cmd migrated to docopts. snapcraft merged Merged PR canonical/snapcraft#143 (commit c947ec280) migrated the clean CLI command to docopts and moved load_config into the yaml module, after positive review from kyrofa and come-maiz.
74%
#135 cli: Move to docopt, help cmd migrated. snapcraft closed Closed unmerged and superseded by canonical/snapcraft#136, which landed the same docopt help-command migration in commit 00642d304. Review feedback was addressed there; tests stayed disabled pending the wider CLI migration.
71%
#150 cli: stage command migrated to docopts snapcraft merged Merged PR #150 (commit 922a96d2f) migrating snapcraft's `stage` CLI command to docopts; looping now runs over steps then parts so `after` dependencies are staged, with approved review from come-maiz and chipaca.
71%