lxd: clean with no parts should only delete
Metadata
Current evaluation
Merged #1434 in commit 33c7a6bc1, making argless LXD clean delete container resources without executing commands inside the container.
Resolution: closed resolved
Reason: PR #1434 was approved and merged as commit 33c7a6bc1, resolving the unnecessary in-container command execution during argless LXD clean.
Evaluated by: mr-cal-bot
No scores available.
Issue body
There's no reason to ever run commands inside a LXD container when `SNAPCRAFT_CONTAINER_BUILDS=1 snapcraft clean` is run without any arguments.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1434 in commit 33c7a6bc1, making argless LXD clean delete container resources without executing commands inside the container. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1434 (commit 33c7a6bc1) made argless LXD clean delete container resources directly without running commands inside the build container. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1434 fixed argless LXD clean: it now deletes container resources without running commands inside the container (commit 33c7a6bc1). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updates snapcraft LXD handling so running clean without arguments only deletes container resources instead of executing commands inside them. Approved by one reviewer and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a change to snapcraft that skips command execution inside LXD containers when running clean without arguments. The update ensures the operation only deletes artifacts, removing unnecessary container overhead. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1762 lxd: delete container only if parts is empty | snapcraft | merged | Merged PR #1762 (dbce9a058), changing LXD cleanup to delete a build container only after all parts are removed, preserving it for targeted cleans and making repeated cleans safe. | |
| #1655 lxd: distinguish argless clean from clean -s pull | snapcraft | merged | Merged in snapcraft#1655 (ed32603c7), fixing LXD cleanup so bare clean removes build containers while clean -s pull preserves or recreates them. | |
| #1587 lifecycle: clean after deleting container | snapcraft | merged | Merged PR #1587 (commit daca4618b): LXD cleanup logic moved into lxd.py's clean() so `snapcraft clean` removes leftover build containers, addressing the forum-reported container-build clean issue. | |
| #1403 lxd: Only remove container if one exists | snapcraft | merged | Merged PR #1403, adding an LXD existence check so failed container creation no longer triggers a second exception while stopping or removing a nonexistent container. | |
| #1456 clean up stale containers | snapcraft | closed | Stale LXD build-container cleanup was implemented in merged PR #1587 (commit daca4618b), moving cleanup into the LXD clean lifecycle. |