lifecycle: clean after deleting container
Metadata
Current evaluation
Merged after addressing reviewer feedback on logic placement. Fixes snapcraft clean not cleaning up after container builds by moving cleanup logic into the container's clean() method. Branch rebased against master and CI passed.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
See [the forum discussion](https://forum.snapcraft.io/t/snapcraft-clean-doesnt-clean-with-snapcraft-container-builds-set/2291/2).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after addressing reviewer feedback on logic placement. Fixes snapcraft clean not cleaning up after container builds by moving cleanup logic into the container's clean() method. Branch rebased against master and CI passed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for snapcraft clean failing to remove container artifacts. Cleanup logic was refactored into the container module's clean() method per maintainer feedback. Tests passed and branch rebased against master. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Fixes snapcraft clean not removing container artifacts by moving cleanup logic to the container's clean method. Reviewers requested architectural adjustments, which were implemented. Tests passed and the branch was rebased to master before merging. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1372 cli: Containerbuild clean | snapcraft | merged | Merged to add a unit test and fix for the SNAPCRAFT_CONTAINER_BUILDS=1 clean command. Approved after reviewer testing issues were addressed and a related bug report was linked. | |
| #1434 lxd: clean with no parts should only delete | snapcraft | merged | Merged. Updates snapcraft LXD handling so running clean without arguments only deletes container resources instead of executing commands inside them. Approved by one reviewer and merged. |