catkin plugin: include-roscore is a boolean
Metadata
Current evaluation
Merged PR #1472 (commit 186473104) changed the catkin plugin's include-roscore value from string 'true' to boolean True, correcting its type without functional impact.
Resolution: closed resolved
Reason: PR canonical/snapcraft#1472 was approved and merged as commit 186473104. It corrected include-roscore to use the proper boolean value; the previous truthy string had not caused functional failures.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Change the string 'true' to the boolean True. Thankfully this had no bad side effects since the string 'true' is truthy, but it's still incorrect and a bad example.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1472 (commit 186473104) changed the catkin plugin's include-roscore value from string 'true' to boolean True, correcting its type without functional impact. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/snapcraft#1472 by maintainer kyrofa, replacing the string 'true' with boolean True for include-roscore in the catkin plugin's handling/example; merged as commit 186473104 (+2/-2 lines, approved by 2 reviewers). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/snapcraft#1472, changing the catkin plugin’s include-roscore value from the string 'true' to boolean True. This corrected the type and example without functional impact. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix replacing the string 'true' with boolean True in the catkin plugin. Corrects an incorrect type and improves code examples without functional impact. Approved by two reviewers. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix replacing the string 'true' with boolean True in the catkin plugin. The change corrects an improperly typed example without affecting functionality, as the original string was already truthy. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #329 Remove roscore plugin. | snapcraft | merged | Merged PR #329 (commit d8413cfdb, merge 228b0f4bf) removed the standalone roscore plugin and added an include-roscore option to the Catkin plugin, closing LP bug #1539169. | |
| #1539169 Remove roscore plugin | snapcraft (launchpad) | closed | Removed the duplicate roscore plugin and added a Catkin include-roscore option via merged snapcraft PR #329 (commit d8413cfdb; merge 228b0f4bf). |