catkin plugin: include-roscore is a boolean
Metadata
Current evaluation
Merged a fix replacing the string 'true' with boolean True in the catkin plugin. Corrects an incorrect type and improves code examples without functional impact. Approved by two reviewers.
Suggested action: —
No scores available.
Issue body
Change the string 'true' to the boolean True. Thankfully this had no bad side effects since the string 'true' is truthy, but it's still incorrect and a bad example.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix replacing the string 'true' with boolean True in the catkin plugin. Corrects an incorrect type and improves code examples without functional impact. Approved by two reviewers. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix replacing the string 'true' with boolean True in the catkin plugin. The change corrects an improperly typed example without affecting functionality, as the original string was already truthy. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix updating the catkin plugin's include-roscore setting from the string 'true' to the boolean True. The change corrects an incorrect type and improves code examples without altering runtime behavior. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #329 Remove roscore plugin. | snapcraft | merged | Merged. Removed the standalone roscore plugin and replaced it with an include-roscore option on the Catkin plugin, resolving Launchpad bug #1539169. | |
| #152 Catkin plugin: Add support for ROS tools. | snapcraft | merged | Merged Catkin plugin updates to properly install ROS packages, include non-source files, and enable ROS tools via an updated wrapper environment. Resolved an xml2-config conflict while planning to remove the redundant roscore plugin. Tests doubled. | |
| #1473 catkin plugin: rosinstall-files is a pull property | snapcraft | merged | Merged a maintainer correction updating the catkin plugin. The rosinstall-files property was incorrectly configured as a push property and has been changed to a pull property. Approved by two reviewers with a three-line fix across two files. | |
| #851 catkin plugin: nicely handle an invalid rosdistro. | snapcraft | merged | Merged changes add rosdistro validation to the catkin plugin, replacing cryptic key errors with clear messages. Approved by reviewers and passed CI. Minor refactoring feedback was noted but did not block the merge. | |
| #842 Catkin plugin: Support ROS Kinetic. | snapcraft | merged | Merged. Adds ROS Kinetic support to the Catkin plugin by refactoring source handling for extensibility and mapping ROS to Ubuntu releases. Fixed a fileutils coverage gap during review. Approved and merged. |