← Back to issue list

Remove roscore plugin.

View original Github issue

Metadata

Project
snapcraft
Number
#329
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #329 (commit d8413cfdb, merge 228b0f4bf) removed the standalone roscore plugin and added an include-roscore option to the Catkin plugin, closing LP bug #1539169.

Resolution: closed resolved

Reason: The PR was merged into snapcraft as commit d8413cfdb with merge commit 228b0f4bf, deleting the roscore plugin (-553/+338 lines across 24 files) and folding its functionality into the Catkin plugin's include-roscore option, closing Launchpad bug #1539169.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR resolves LP: [#1539169](https://bugs.launchpad.net/snapcraft/+bug/1539169) by removing the roscore plugin and replacing it with an `include-roscore` option on the Catkin plugin.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #329 (commit d8413cfdb, merge 228b0f4bf) removed the standalone roscore plugin and added an include-roscore option to the Catkin plugin, closing LP bug #1539169.
stealth/space-bunny-alpha — closed resolved Merged PR #329 removed the standalone roscore plugin and replaced it with the Catkin plugin's include-roscore option, resolving LP #1539169.
qwen/qwen3.6-35b-a3b — — Merged. Removed the standalone roscore plugin and replaced it with an include-roscore option on the Catkin plugin, resolving Launchpad bug #1539169.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Replaced the standalone roscore plugin with an include-roscore option on the Catkin plugin, resolving Launchpad bug #1539169.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1539169 (confidence 95%)

    Launchpad bug 1539169 'Remove roscore plugin', the upstream tracker item this PR explicitly resolves and which is now closed

  • Likely Fixed By: snapcraft#1472 (confidence 88%)

    Follow-up merged PR (commit 186473104) correcting include-roscore to a boolean, confirming #329's option survived into the current catkin plugin

Related issues

Issue Project State Summary Similarity
#1539169 Remove roscore plugin snapcraft (launchpad) closed Removed the duplicate roscore plugin and added a Catkin include-roscore option via merged snapcraft PR #329 (commit d8413cfdb; merge 228b0f4bf).
90%
#1472 catkin plugin: include-roscore is a boolean snapcraft merged Merged PR #1472 (commit 186473104) changed the catkin plugin's include-roscore value from string 'true' to boolean True, correcting its type without functional impact.
74%