← Back to issue list

cli: stage command migrated to docopts

View original Github issue

Metadata

Project
snapcraft
Number
#150
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #150 (commit 922a96d2f) migrating snapcraft's `stage` CLI command to docopts; looping now runs over steps then parts so `after` dependencies are staged, with approved review from come-maiz and chipaca.

Resolution: closed resolved

Reason: PR #150 was merged into master as commit 922a96d2f ('cli: stage command migrated to docopts', 7 files, +401/-147), landing the docopts rewrite of the stage command with should_stage_run/step-first ordering. Reviewer @come-maiz approved 'merge when you are happy', with test-coverage follow-ups deferred to later branches.

Evaluated by: mr-cal-bot

No scores available.

Issue body

What differs from the previous implementation is that the looping is done on the `steps` first and then on the `parts`, this makes the fact that `after` handling needs fixing right now instead of later as a _part_ depending on another needs to have its assets `staged`.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #150 (commit 922a96d2f) migrating snapcraft's `stage` CLI command to docopts; looping now runs over steps then parts so `after` dependencies are staged, with approved review from come-maiz and chipaca.
stealth/space-bunny-alpha — closed resolved Merged PR #150 by sergiusens: `snapcraft internal stage` migrated to docopts; loop restructured to run steps before parts so assets needed for `after` handling are staged first.
stealth/space-bunny-alpha — closed resolved Merged the stage CLI migration to docopts in commit 922a96d2f, processing steps before parts so assets needed by after handling are staged first.
stealth/space-bunny-alpha — closed resolved Merged the stage command's migration to docopts, including step-before-part processing. Commit 922a96d2f.
qwen/qwen3.6-35b-a3b — — Migrated the stage command to docopts. Resolved reviewer feedback regarding execution loop logic and test coverage. Approved by maintainers and merged.
qwen3.6-35b-a3b-mtp-q6 — — Migrated the stage command to docopts and restructured loops to correctly stage dependent parts. Incorporated reviewer feedback to improve test coverage and logic. Approved and merged.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#145 (confidence 70%)

    Part of the same docopts CLI migration series (commit 7f09faa72 for the pull command), which this PR follows.

  • Related To: canonical/snapcraft#144 (confidence 65%)

    Same docopts migration series (commit 2ed68dde2, init command).

  • Related To: canonical/snapcraft#151 (confidence 62%)

    Subsequent docopts migration of the strip command (commit 6251b86f3), merged after this PR.

  • Caused By: canonical/snapcraft#136 (confidence 45%)

    The overall 'cli: Move to docopt' effort that this per-command migration continues.

Related issues

Issue Project State Summary Similarity
#144 cli: init cmd migrated to docopts. snapcraft merged PR #144 by sergiusens merged the `snapcraft init` CLI command onto the docopts-based command framework (commit 2ed68dde2, 4 files, +104/-63), part of the incremental docopts migration series.
71%
#151 cli: strip command migrated to docopts snapcraft merged Merged PR #151, migrating Snapcraft's strip CLI command to docopts in commit 6251b86f3 across six files.
71%
#149 cli: build command migrated to docopts snapcraft merged Merged the build command's migration to docopts in commit 84aa15f34, changing 3 files (+164/-8); @come-maiz approved it with one copy-paste correction.
70%