← Back to issue list

pluginhandler: clean error for BasePlugin.run{,_output}

View original Github issue

Metadata

Project
snapcraft
Number
#1512
Type
pull request
State
closed
Author
kalikiana
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged after recurring Travis failures; clean command-failure errors were later implemented by #2132 in commit 4936eff8c.

Resolution: closed superseded

Reason: The author closed the PR after download failures, Travis timeouts, and a blocking I/O error prevented reliable testing. Its intended behavior was later delivered by merged PR #2132 in commit 4936eff8c.

Evaluated by: mr-cal-bot

No scores available.

Issue body

I was snapping a cmake project the other day, and a typo in my configflags gave me a 50 lines traceback even when I wasn't using --debug... this should be handled by a SnapcraftError.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged after recurring Travis failures; clean command-failure errors were later implemented by #2132 in commit 4936eff8c.
stealth/space-bunny-alpha — closed superseded Closed unmerged after Travis failures; clean subprocess error handling was later implemented by merged PR #2132 in commit 4936eff8c.
stealth/space-bunny-alpha — closed superseded Closed unmerged after unreliable CI; merged PR canonical/snapcraft#2132 later implemented clean errors for common.run and common.run_output in commit 4936eff8c.
stealth/space-bunny-alpha — closed superseded Closed unmerged after Travis failures; clean handling for common.run/run_output was later implemented by merged PR #2132 in commit 4936eff8c.
stealth/space-bunny-alpha — closed superseded PR #1512 (kalikiana) to make BasePlugin.run/run_output raise a clean SnapcraftError was approved but closed unmerged after flaky Travis failures (timeouts, download errors, BlockingIOError). Later addressed by merged PR #2132 (commit 4936eff8c).
stealth/space-bunny-alpha — closed superseded Closed unmerged after Travis timeouts, download failures, and a blocking I/O error prevented reliable testing. Later handled by merged PR #2132 (4936eff8c).
qwen/qwen3.6-35b-a3b — — Closed without merging due to persistent CI failures on Travis, including timeouts and blocking I/O errors. The author paused work to resolve testability issues.
qwen3.6-35b-a3b-mtp-q6 — — Abandoned and closed without merging due to persistent CI test failures on Travis. The author paused work to resolve flaky tests and make them reliably pass.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#2132 (confidence 99%)

    Merged replacement adding consumable errors for failed common.run and common.run_output calls.

  • Related To: canonical/snapcraft#2004 (confidence 88%)

    Merged dedicated SnapcraftError handling for plugin command failures in commit 2308ee4e0.

Related issues

No related issues found above the similarity threshold.