← Back to issue list

node plugin: record installed node packages in manifest

View original Github issue

Metadata

Project
snapcraft
Number
#1523
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1523, adding Node plugin manifest recording for installed Node.js packages in commit e0ee75ac8 as part of snapcraft#1453.

Resolution: closed resolved

Reason: The approved PR was merged after conflicts were resolved. Commit e0ee75ac8 implements manifest recording for installed Node.js packages.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- This is part of #1453.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1523, adding Node plugin manifest recording for installed Node.js packages in commit e0ee75ac8 as part of snapcraft#1453.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#1523, adding manifest recording of installed Node.js packages after review approval and conflict resolution.
stealth/space-bunny-alpha — closed resolved Merged PR #1523 (commit e0ee75ac8), adding manifest recording of installed Node.js packages; this implemented part of #1453.
qwen/qwen3.6-35b-a3b — — Merged to record installed node packages in the manifest via the node plugin. Approved by two reviewers after resolving merge conflicts. Implements part of issue #1453.
qwen3.6-35b-a3b-mtp-q6 — — Merged after resolving merge conflicts. The node plugin now records installed Node.js packages in the manifest as part of issue #1453.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1453 (confidence 99%)

    The PR body explicitly identifies the work as part of the broader Node.js plugin recording issue.

Related issues

Issue Project State Summary Similarity
#1524 node plugin: record the yarn.lock file snapcraft merged Merged in snapcraft#1524 via commit 4055b4f15, adding yarn.lock recording to the Node.js plugin as part of snapcraft#1453.
70%