node plugin: record the yarn.lock file
Metadata
Current evaluation
Merged in snapcraft#1524 via commit 4055b4f15, adding yarn.lock recording to the Node.js plugin as part of snapcraft#1453.
Resolution: closed resolved
Reason: PR #1524 was merged with commit 4055b4f15, implementing yarn.lock recording and completing this portion of the Node.js plugin recording work tracked by #1453.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
This is part of #1453.
Requires #1523
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#1524 via commit 4055b4f15, adding yarn.lock recording to the Node.js plugin as part of snapcraft#1453. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#1524 via commit 4055b4f15, adding yarn.lock recording to the node plugin as part of #1453 and alongside #1523. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged pull request by come-maiz that records the yarn.lock file in the node plugin. Approved by two reviewers, the change adds 31 lines across two files to ensure yarn lockfiles are properly tracked during snap builds. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to add yarn.lock file recording to the node plugin. This implements dependency tracking as part of issue #1453 and depends on #1523. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#1453
(confidence 100%)
Umbrella Node.js plugin recording issue explicitly referenced by PR #1524.
-
Related To:
snapcraft#1523
(confidence 99%)
Required prerequisite PR that recorded installed Node.js packages in the manifest.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1523 node plugin: record installed node packages in manifest | snapcraft | merged | Merged PR #1523, adding Node plugin manifest recording for installed Node.js packages in commit e0ee75ac8 as part of snapcraft#1453. | |
| #1245 nodejs plugin: add support for yarn. | snapcraft | merged | Merged Yarn support for Snapcraft's Node.js plugin in PR #1245 (commit 824a8ba79); the Yarn build test passed despite a Travis timeout. |