catkin plugin: don't assume catkin is in underlay
Metadata
Current evaluation
Merged #1526 in commit ae9fd598f, making the Catkin plugin use its isolated Catkin installation instead of requiring Catkin in the underlay; fixes LP #1696014.
Resolution: closed resolved
Reason: The merged change uses the plugin's isolated Catkin installation for all Catkin components, resolving underlays that do not contain Catkin. Commit ae9fd598f records the fix.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Currently the Catkin plugin pulls its own Catkin off to the side in order to search for dependencies in the underlay, but then doesn't use it in isolation, using Catkin components out of the underlay. This breaks if the underlay doesn't actually include Catkin, and makes no sense considering that Catkin is already pulled off to the side. This PR fixes LP: [#1696014](https://bugs.launchpad.net/snapcraft/+bug/1696014) by using that version completely.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1526 in commit ae9fd598f, making the Catkin plugin use its isolated Catkin installation instead of requiring Catkin in the underlay; fixes LP #1696014. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1526 (commit ae9fd598f) updated the Catkin plugin to use its isolated Catkin installation, fixing LP #1696014. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1526 (commit ae9fd598f), fixing the Catkin plugin to use its isolated Catkin consistently instead of assuming Catkin exists in the underlay. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1526 (commit ae9fd598f) to use the Catkin plugin's isolated Catkin installation, removing the requirement that the underlay contain Catkin and fixing LP #1696014. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1526 (commit ae9fd598f) updates the Catkin plugin to use its isolated Catkin installation instead of requiring Catkin in the underlay, resolving LP #1696014. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix updating the catkin plugin to use its isolated installation instead of assuming catkin exists in the underlay. Resolves Launchpad bug #1696014. Includes reviewer-requested test naming updates. Approved and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for the Catkin plugin to use its isolated Catkin version instead of assuming the underlay contains it, resolving LP: #1696014. Integration test naming was updated per reviewer feedback before merging. |
Update history
No update history recorded yet.
Related work
-
Caused By:
snapcraft (launchpad)#1696014
(confidence 99%)
Launchpad bug #1696014 identified the Catkin-underlay failure fixed by PR #1526.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1696014 catkin plugin _Catkin.find always fails | snapcraft (launchpad) | closed | Fixed by merged PR #1526: commit ae9fd598f updated the Catkin plugin to stop assuming Catkin exists in the underlay. | |
| #1140 [WIP] catkin plugin: support building with an underlay. | snapcraft | merged | Merged PR #1140 in commit cab0b3806, adding build- and run-time underlay support to the Catkin plugin so ROS dependencies can be shared instead of bundled. | |
| #1354 catkin plugin: fix pythonpath for catkin_find | snapcraft | closed | Closed unmerged after inactivity; its linked catkin-underlay failure was later fixed by merged PR #1526 in commit ae9fd598f. | |
| #1664776 Catkin plugin: support building with an underlay | snapcraft (launchpad) | closed | Catkin underlay support landed in snapcore/snapcraft#1140 (cab0b3806); follow-up #1186 added a ROS content-sharing demo. | |
| #1743 catkin plugin: support building entire workspace | snapcraft | merged | Merged #1743 in commit ec4cac26a, making catkin-packages optional so the Catkin plugin builds the entire workspace when omitted; this also resolves snapcraft#1713. |