← Back to issue list

catkin plugin: fix pythonpath for catkin_find

View original Github issue

Metadata

Project
snapcraft
Number
#1354
Type
pull request
State
closed
Author
mrjogo
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged after inactivity; its linked catkin-underlay failure was later fixed by merged PR #1526 in commit ae9fd598f.

Resolution: closed superseded

Reason: PR #1354 was closed without merging after inactivity. LP bug #1696014 was subsequently fixed by merged PR #1526 (commit ae9fd598f), which made the plugin use its isolated Catkin installation instead of one from an underlay.

Evaluated by: mr-cal-bot

No scores available.

Issue body

ROS has separate python package location that needs to be on PYTHONPATH before calling catkin_find in the generated bash script. Fixes false script failures, which the plugin interprets as not finding the specified package. LP: [#1696014](https://bugs.launchpad.net/snapcraft/+bug/1696014)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged after inactivity; its linked catkin-underlay failure was later fixed by merged PR #1526 in commit ae9fd598f.
stealth/space-bunny-alpha — closed stale Closed unmerged for inactivity on 2017-07-19; no resolving commit was recorded. The author later moved discussion of the still-occurring problem to a separate forum thread.
qwen/qwen3.6-35b-a3b — — Closed and abandoned. The author clarified the fix only resolved a highly specific local setup issue and was no longer relevant. The underlying problem persisted, prompting further troubleshooting on the forum instead of merging the changes.
qwen3.6-35b-a3b-mtp-q6 — — Closed due to inactivity. The author clarified the fix was environment-specific and no longer relevant, though the underlying catkin underlay conflict persists and was moved to a forum discussion.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#1526 (confidence 97%)

    The later merged PR addressed the same linked LP bug with a broader catkin-underlay fix.

Related issues

Issue Project State Summary Similarity
#1696014 catkin plugin _Catkin.find always fails snapcraft (launchpad) closed Fixed by merged PR #1526: commit ae9fd598f updated the Catkin plugin to stop assuming Catkin exists in the underlay.
81%
#324 catkin plugin: do not overwrite the PYTHONPATH snapcraft merged Merged PR #324 fixed the catkin plugin to preserve setup.sh’s PYTHONPATH instead of overwriting it, resolving LP #1544790.
74%
#1526 catkin plugin: don't assume catkin is in underlay snapcraft merged Merged #1526 in commit ae9fd598f, making the Catkin plugin use its isolated Catkin installation instead of requiring Catkin in the underlay; fixes LP #1696014.
73%
#1522 catkin plugin: only append PYTHONPATH if set snapcraft merged Merged in commit a2440c986: the Catkin plugin now appends PYTHONPATH only when set, preventing empty path segments; environment-output coverage was added.
71%
#1714333 Catkin plugin: empty segment added to PYTHONPATH snapcraft (launchpad) closed Fixed by snapcraft PR #1522, merged as commit a2440c986 ("catkin plugin: only append PYTHONPATH if set"), which makes the Catkin plugin append the existing PYTHONPATH only when it is set, avoiding an empty path segment.
71%