jhbuild plugin: fix UnboundLocalError for chmod_path
Metadata
Current evaluation
PR #1534 merged as commit 67089e050, moving the for-loop into the scope of `chmod_path` in the jhbuild plugin to fix the UnboundLocalError from LP bug #1715507.
Resolution: closed resolved
Reason: Merged to master as commit 67089e050 ("jhbuild plugin: fix UnboundLocalError for chmod_path (#1534)"), a +5/-5 change to snapcraft/plugins/jhbuild.py approved by two reviewers; sergiusens confirmed CI was green.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Move for-loop into the same scope as the variable `chmod_path`.
fixes: https://bugs.launchpad.net/snapcraft/+bug/1715507
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh unit`?
Failing test groups:
- snapcraft.tests.sources.test_mercurial.MercurialDetailsTestCase
- snapcraft.tests.test_deltas.BaseDeltaGenerationTestCase
- snapcraft.tests.test_deltas_xdelta3.XDelta3TestCase
- snapcraft.tests.commands.test_push.PushCommandDeltasTestCase
None of those touch the jhbuild plugin so I propose the merge anyway.
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #1534 merged as commit 67089e050, moving the for-loop into the scope of `chmod_path` in the jhbuild plugin to fix the UnboundLocalError from LP bug #1715507. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#1534, commit 67089e050, fixing the jhbuild plugin chmod_path UnboundLocalError by placing the loop in the same scope; addresses Launchpad bug 1715507. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for an UnboundLocalError in the jhbuild plugin by moving the for-loop into the correct scope for chmod_path. Approved by reviewers and CI, the change resolved the referenced bug. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for an UnboundLocalError in the jhbuild plugin by moving a for-loop into the same scope as chmod_path. The maintainer approved the merge after confirming the build was green, despite unrelated test failures. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#1535
(confidence 60%)
Follow-up merged PR removing the jhbuild plugin's pkgconf dependency (commit f93850027), same file.
-
Related To:
canonical/snapcraft#2371
(confidence 55%)
Later commit b46e3f678 removed the jhbuild plugin entirely, making the fix moot in current code.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1715507 jhbuild fails with: 'chmod_path' referenced before assignment | snapcraft (launchpad) | closed | UnboundLocalError in the jhbuild plugin's _setup_jhbuild (chmod_path referenced before assignment) was fixed by PR #1534, commit 67089e0 "jhbuild plugin: fix UnboundLocalError for chmod_path"; maintainer ~sergiusens closed the bug after merging. |