← Back to issue list

plugins: remove jhbuild

View original Github issue

Metadata

Project
snapcraft
Number
#2371
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged removal of the unused, bases-incompatible jhbuild plugin, resolving LP #1794789. The change deletes 503 lines across 8 files following reviewer approval and passing CI checks.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? ----- The jhbuild plugin isn't compatible with bases and isn't used by anyone as far as we're aware (including its original author). This PR resolves [LP: #1794789](https://bugs.launchpad.net/snapcraft/+bug/1794789) by removing it for now; if someone needs it we can add it back.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged removal of the unused, bases-incompatible jhbuild plugin, resolving LP #1794789. The change deletes 503 lines across 8 files following reviewer approval and passing CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged removal of the unused and bases-incompatible jhbuild plugin, resolving LP: #1794789. Approved after an unrelated rust test failure was identified.
qwen3.6-35b-a3b-mtp-q6 Merged removal of the jhbuild plugin due to base incompatibility and zero usage, resolving LP: #1794789. The change was accepted despite an unrelated rust test failure.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1794789 Remove the jhbuild plugin snapcraft (launchpad) closed The jhbuild plugin was removed due to lacking base awareness and zero usage. The maintainer closed the issue directly, dropping the unused component without further discussion.
80%
#1535 jhbuild plugin: remove dependency on pkgconf snapcraft merged Merged changes remove the pkgconf dependency from the jhbuild plugin to resolve a pkg-config conflict. Approved by three reviewers, passed CI checks, and deleted one line.
79%
#2376 jdk plugin: remove jdk snapcraft merged Merged the JDK plugin removal. Approved by a reviewer, passed CI, and deleted 51 lines across three files to address Launchpad bug #1794788.
77%
#812 New plugin: jhbuild snapcraft closed Superseded by pull request #924, which implements the jhbuild plugin without requiring LXC. The original was closed with unresolved review comments after the author noted the replacement.
76%
#2308 plugins: remove the copy plugin when using a base snapcraft merged Merged into master. Removes the copy plugin when a base is specified. Updated spread tests to verify backwards compatibility. Approved by reviewer, passed CI, and integrated with a net reduction of 622 lines across eight files.
72%
#1298 jhbuild plugin: new plugin snapcraft merged Merged a new JHBuild plugin for Snapcraft. The contributor removed a Xenial-incompatible dependency, simplified code, and resolved reviewer concerns regarding dependency resolution. Following maintainer approval, the plugin was integrated into the codebase.
72%
#2326 plugins: remove implicit source snapcraft merged Merged. Removes implicit source from plugins, resolving Launchpad bug #1776807. Approved, passed CI, and refined internal logic from PR #2300. Updated 46 files (+84/-59 lines).
72%
#924 New plugin: jhbuild snapcraft closed The jhbuild plugin was closed and abandoned pending clarification on bubblewrap compatibility with Ubuntu Xenial. Maintainers cited versioning conflicts and requested a decision before resubmission.
70%