← Back to issue list

plugins: remove jhbuild

View original Github issue

Metadata

Project
snapcraft
Number
#2371
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

PR #2371 (commit b46e3f678) by kyrofa merged, deleting the unused, base-incompatible jhbuild plugin (-503 lines, 8 files), resolving LP bug #1794789. No jhbuild references remain in the repo.

Resolution: closed resolved

Reason: The PR itself was merged into master as commit b46e3f678, removing snapcraft/plugins/jhbuild entirely. A grep of the current tree shows zero remaining jhbuild references, and the PR body states it resolves LP: #1794789 by removing the plugin until someone needs it.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? ----- The jhbuild plugin isn't compatible with bases and isn't used by anyone as far as we're aware (including its original author). This PR resolves [LP: #1794789](https://bugs.launchpad.net/snapcraft/+bug/1794789) by removing it for now; if someone needs it we can add it back.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #2371 (commit b46e3f678) by kyrofa merged, deleting the unused, base-incompatible jhbuild plugin (-503 lines, 8 files), resolving LP bug #1794789. No jhbuild references remain in the repo.
stealth/space-bunny-alpha — closed resolved Merged PR #2371 (b46e3f678), removing the unused jhbuild plugin because it was incompatible with bases. The maintainer noted it could be restored if needed.
qwen/qwen3.6-35b-a3b — — Merged removal of the unused, bases-incompatible jhbuild plugin, resolving LP #1794789. The change deletes 503 lines across 8 files following reviewer approval and passing CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of the unused and bases-incompatible jhbuild plugin, resolving LP: #1794789. Approved after an unrelated rust test failure was identified.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1298 (confidence 85%)

    PR #1298 (f5a51ee09) originally introduced the jhbuild plugin that #2371 removed; later fixes #1534, #1535 and #2141 touched it before removal.

  • Likely Fixed By: snapcraft#2141 (confidence 60%)

    PR #2141 (a017389fd) allowed jhbuild to run as root, an interim fix superseded by the plugin's removal.

Related issues

Issue Project State Summary Similarity
#1794789 Remove the jhbuild plugin snapcraft (launchpad) closed Maintainer sergiusens asked to drop the unused, non-base-aware jhbuild plugin. Resolved by merged PR snapcore/snapcraft#2371 (commit b46e3f678, "plugins: remove jhbuild", ~503 lines removed); no jhbuild references remain in the tree.
79%
#1535 jhbuild plugin: remove dependency on pkgconf snapcraft merged Merged PR #1535 (commit f93850027) removed the jhbuild plugin's pkgconf dependency, resolving its conflict with pkg-config (>= 0.29-1).
77%
#1298 jhbuild plugin: new plugin snapcraft merged Merged PR #1298 (commit f5a51ee09) landed a rewritten, Bubblewrap-free JHBuild plugin by lucyllewy, replacing earlier attempt #924; approved by jhenstridge/kyrofa after review. Plugin later removed in #2371 as base-incompatible.
76%
#812 New plugin: jhbuild snapcraft closed PR #812 (LXC-based jhbuild plugin by attente, 2016) was closed unmerged in Nov 2016, superseded by #924, which in turn was replaced by the Bubblewrap-free rewrite merged as #1298 (commit f5a51ee09); plugin later removed in #2371.
75%
#2308 plugins: remove the copy plugin when using a base snapcraft merged Merged PR #2308 via commit 360453fa6, removing the copy plugin for base-based builds while preserving and testing legacy no-base compatibility.
71%