← Back to issue list

store: handle revoked developers

View original Github issue

Metadata

Project
snapcraft
Number
#1554
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1554 as commit 0faf6dcdd, adding revoked-developer handling and refactoring assertion presentation for CLI components.

Resolution: closed resolved

Reason: PR #1554 was approved and merged into snapcraft as commit 0faf6dcdd, implementing the requested revoked-developer behavior.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add logic to handle revoking developers from the collaboration feature. This work includes a refactor on how assertions are presented to the components that handle the CLI. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1554 as commit 0faf6dcdd, adding revoked-developer handling and refactoring assertion presentation for CLI components.
stealth/space-bunny-alpha — closed resolved Merged #1554 (0faf6dcdd), adding store handling for revoked developers and refactoring assertion presentation for CLI components.
qwen/qwen3.6-35b-a3b — — Merged. Added logic to handle revoked developers in the collaboration feature and refactored CLI assertion presentation. Approved by one reviewer, passed CI, and modified 12 files. Docstring and test updates remain pending.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Adds logic to handle revoked developers in the collaboration feature and refactors assertion presentation for CLI components. Author noted pending tests for the assertions module and addressed docstring updates during review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3422 Revert "cli: allow validation assertions to be revoked (#3417)" snapcraft merged Merged PR #3422 (commit be94581c8) reverted commit 847cd3cd4 from #3417 after revoke support failed against the store; revocation was re-landed later in #3433 (612d4b317).
71%