Revert "cli: allow validation assertions to be revoked (#3417)"
Metadata
Current evaluation
Merged PR #3422 (commit be94581c8) reverted commit 847cd3cd4 from #3417 after revoke support failed against the store; revocation was re-landed later in #3433 (612d4b317).
Resolution: closed resolved
Reason: The PR itself was merged into master as commit be94581c8, undoing the --revoke/--no-revoke flags added by #3417 because revoking an existing assertion errored (see launchpad bug 1912332). Revocation was subsequently re-implemented correctly in #3433 (commit 612d4b317).
Evaluated by: mr-cal-bot
No scores available.
Issue body
This reverts commit 847cd3cd4fa9c7e67231816a84c45bf3070fbef2.
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3422 (commit be94581c8) reverted commit 847cd3cd4 from #3417 after revoke support failed against the store; revocation was re-landed later in #3433 (612d4b317). | |
| stealth/space-bunny-alpha | — | closed superseded | Merged PR #3422 (commit be94581c8) is a pure revert of 847cd3c (#3417), removing the `snapcraft validate --revoke` CLI flags; the revocation feature was re-landed later in #3433 (612d4b317). | |
| stealth/space-bunny-alpha | — | closed superseded | Maintainer PR #3422 merged as commit be94581c8, reverting 847cd3cd4 (PR #3417) that added --revoke/--no-revoke flags to `snapcraft validate`. Feature was re-landed shortly after by #3433 (612d4b317). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3422 (commit be94581c8), reverting 847cd3c and removing CLI support for revoking validation assertions. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a revert PR that undoes the previous commit allowing validation assertions to be revoked. Approved by a maintainer, passed CI checks, and successfully integrated into master with stable code coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a revert of commit 847cd3c, undoing the feature that allowed CLI validation assertions to be revoked. The change was integrated into master with 100% diff coverage by maintainer sergiusens. |
Update history
No update history recorded yet.
Related work
-
Duplicate Of:
canonical/snapcraft#3417
(confidence 95%)
Reverts commit 847cd3cd4, the merge of #3417, with a 2 file +2/-57 line diff.
-
Superseded By:
canonical/snapcraft#3433
(confidence 90%)
Commit 612d4b317 'cli: allow revoking validation assertions' re-added revocation after this revert, per launchpad bug 1912332.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3417 Allow validation assertions to be revoked | snapcraft | merged | PR #3417 merged as 847cd3cd4, but was reverted by #3422 (be94581c8); corrected revocation support was merged in #3433 (612d4b317). | |
| #3433 Allow revoking validation assertions (LP: #1912332) | snapcraft | merged | Merged #3433 restored CLI support for revoking validation assertions after #3417 was reverted by #3422, resolving LP #1912332; landed as 612d4b317. | |
| #1554 store: handle revoked developers | snapcraft | merged | Merged PR #1554 as commit 0faf6dcdd, adding revoked-developer handling and refactoring assertion presentation for CLI components. |