← Back to issue list

static: fix flake8 errors in setup.py

View original Github issue

Metadata

Project
snapcraft
Number
#1559
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged after fixing flake8 errors in setup.py. Approved by two reviewers with zero unresolved comments. The commit modified two files, adding 102 and removing 103 lines.

Suggested action:

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after fixing flake8 errors in setup.py. Approved by two reviewers with zero unresolved comments. The commit modified two files, adding 102 and removing 103 lines.
qwen3.6-35b-a3b-mtp-q6 Merged a pull request by maintainer sergiusens that resolves flake8 linting errors in setup.py. The changes passed static and unit tests and were successfully integrated into the codebase.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for flake8 errors in setup.py by maintainer sergiusens. The changes passed static and unit tests, resolving linting compliance issues.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2902 static: fix some valid flake8 issues snapcraft merged Merged. Fixed unused typing imports flagged by flake8 across five Python files. Changes were approved, passed CI checks, and integrated into the codebase.
79%
#79 Minor fixes to setup.py snapcraft merged Merged external contribution removing unused imports and fixing flake8 formatting in setup.py. Approved by sergiusens, altering one file with 17 additions and 18 deletions.
76%
#2229 style: fix linting errors charmcraft merged Merged changes resolving linting errors from the latest ruff and pyright. Approved by two reviewers with zero unresolved comments. Updated 8 files, removing 22 lines overall.
71%