← Back to issue list

static: fix flake8 errors in setup.py

View original Github issue

Metadata

Project
snapcraft
Number
#1559
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1559 fixed Flake8 errors in setup.py via commit 66954305e.

Resolution: closed resolved

Reason: PR #1559 was approved and merged, resolving the lint failures in commit 66954305e.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1559 fixed Flake8 errors in setup.py via commit 66954305e.
stealth/space-bunny-alpha — closed resolved PR #1559 by maintainer sergiusens fixed flake8 lint errors in setup.py; it was approved and merged as commit 66954305e ('static: fix flake8 errors in setup.py'), touching 2 files (+102/-103).
stealth/space-bunny-alpha — closed resolved Merged static fixes for setup.py Flake8 errors in commit 66954305e.
stealth/space-bunny-alpha — closed resolved Merged PR #79, which removed unused imports and corrected flake8 formatting in setup.py.
qwen/qwen3.6-35b-a3b — — Merged after fixing flake8 errors in setup.py. Approved by two reviewers with zero unresolved comments. The commit modified two files, adding 102 and removing 103 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged a pull request by maintainer sergiusens that resolves flake8 linting errors in setup.py. The changes passed static and unit tests and were successfully integrated into the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2902 static: fix some valid flake8 issues snapcraft merged Merged as commit cfa69b164: PR #2902 by sergiusens removed 7 unused typing imports (F401) across 5 files in catkin.py, _pip.py, errors.py, _config.py and _status_cache.py, fixing flake8 findings.
79%
#2420 static: update to the latest flake8 snapcraft merged Merged PR updated flake8 to the latest version (LP #1807409) plus related static-check tweaks across 18 files (+34/-33); landed as commit 1b9a7d933.
73%
#3019 static: consolidate tooling setup to setup.cfg snapcraft merged Merged #3019 as commit a0b32a893, consolidating static-analysis tooling into setup.cfg and removing the separate .flake8 configuration.
72%
#79 Minor fixes to setup.py snapcraft merged PR #79 (plars) removing unused imports and fixing flake8 formatting in setup.py was merged into snapcraft's master via commit 8160bdcd (merge b7fce1565).
71%