static: update to the latest flake8
Metadata
Current evaluation
Merged PR updated flake8 to the latest version (LP #1807409) plus related static-check tweaks across 18 files (+34/-33); landed as commit 1b9a7d933.
Resolution: closed resolved
Reason: The PR was merged into snapcore/snapcraft as commit 1b9a7d933 ("static: update to the latest flake8 (#2420)"), bumping the flake8 pin and adjusting static-test expectations across 18 files. The only comment was an automated Codecov report.
Evaluated by: mr-cal-bot
No scores available.
Issue body
LP: #1807409
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR updated flake8 to the latest version (LP #1807409) plus related static-check tweaks across 18 files (+34/-33); landed as commit 1b9a7d933. | |
| stealth/space-bunny-alpha | — | closed resolved | Flake8 was updated to the latest version, with related static-check adjustments. PR #2420 merged as commit 1b9a7d933. | |
| qwen/qwen3.6-35b-a3b | — | — | Successfully merged update to the latest flake8 version. Authored by maintainer sergiusens and linked to Launchpad issue #1807409, the dependency upgrade was integrated without blocking issues. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged the pull request to update flake8 to the latest version. The change passed static checks and achieved 83.33% diff coverage per Codecov. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#1745
(confidence 70%)
Earlier PR 'static tests: upgrade to the newest flake8' (commit cffca5aa4), a prior increment of the same lint-tool dependency.
-
Superseded By:
snapcraft#4012
(confidence 45%)
Later the project migrated linting away from flake8 to ruff (commit a6e7d5f9d), making this flake8 pin obsolete in current tree.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1745 static tests: upgrade to the newest flake8 | snapcraft | merged | Merged PR #1745 upgraded static tests to the newest flake8 and fixed detected lint violations across nine files in commit cffca5aa4. | |
| #1807409 move to newer flake8 | snapcraft (launchpad) | closed | Bumped flake8 to the latest version via snapcore/snapcraft#2420 (commit 1b9a7d933, merged Dec 2018), which bumped the pin and made related static-check fixes across 18 files. | |
| #2902 static: fix some valid flake8 issues | snapcraft | merged | Merged as commit cfa69b164: PR #2902 by sergiusens removed 7 unused typing imports (F401) across 5 files in catkin.py, _pip.py, errors.py, _config.py and _status_cache.py, fixing flake8 findings. | |
| #1559 static: fix flake8 errors in setup.py | snapcraft | merged | Merged PR #1559 fixed Flake8 errors in setup.py via commit 66954305e. |