tests: simplify a little the data in nodejs unit tests
Metadata
Current evaluation
Merged in snapcraft#1563 via commit 6d5d510e7, simplifying data used by Node.js unit tests; approved with no unresolved review comments.
Resolution: closed resolved
Reason: PR #1563 was merged as commit 6d5d510e7. It reduced the Node.js unit-test data by 47 net lines (+31/-78) and received one approval.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#1563 via commit 6d5d510e7, simplifying data used by Node.js unit tests; approved with no unresolved review comments. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1563 in commit 6d5d510e7, simplifying Node.js unit-test data and reducing the test diff from 109 to 31 added lines. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1563, simplifying Node.js unit-test data in one file (+31/-78 lines) with one approval and no unresolved review comments. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a pull request simplifying test data in Node.js unit tests. Approved by one reviewer, passed CI checks, and reduced 78 lines while adding 31 across a single file. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a pull request by come-maiz that simplifies test data in Node.js unit tests. The changes were accepted and integrated into the main branch without additional comments or revisions. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1609 tests: remove the duplicate nodejs integration tests | snapcraft | merged | Merged in snapcraft#1609 via commit d0be68b68, removing duplicate Node.js integration tests already covered by unit tests for npm as the default. |