tests: remove the duplicate nodejs integration tests
Metadata
Current evaluation
Merged in snapcraft#1609 via commit d0be68b68, removing duplicate Node.js integration tests already covered by unit tests for npm as the default.
Resolution: closed resolved
Reason: PR #1609 was merged into main as commit d0be68b68. It removed redundant Node.js integration tests because unit tests already verified npm as the default package manager, saving 2–3 minutes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The integration tests for the default package manager doesn't provide any
useful information. We have a unittest that checks that the default value
is npm.
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#1609 via commit d0be68b68, removing duplicate Node.js integration tests already covered by unit tests for npm as the default. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#1609 as commit d0be68b68, removing redundant Node.js integration tests that duplicated the unit test confirming npm as the default package manager. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of redundant Node.js integration tests. They duplicated existing unit checks for the default npm package manager and extended CI runtime. Reviewers approved the cleanup, saving 2-3 minutes per run. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of duplicate Node.js integration tests. The changes eliminate redundant checks already covered by unit tests, reducing CI execution time by two to three minutes. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1563 tests: simplify a little the data in nodejs unit tests | snapcraft | merged | Merged in snapcraft#1563 via commit 6d5d510e7, simplifying data used by Node.js unit tests; approved with no unresolved review comments. | |
| #2353 tests: remove dependency on snapcraft for integration tests | snapcraft | merged | PR #2353 by sergiusens merged as commit 6a7c860c4, dropping snapcraft imports from integration tests (27 files, +956/-733) so the suite no longer depends on snapcraft and tests stay independent, alongside the bases/multipass cleanup. | |
| #1716 tests: split the integration autopkgtests | snapcraft | merged | Merged in snapcraft#1716 via 57af155a7, splitting integration autopkgtests into separate runs to prevent timeout failures despite added setup overhead. | |
| #1625 tests: use the snapcraft snap for integration tests | snapcraft | merged | Merged PR #1625 updated integration tests to run the installed Snapcraft snap, better matching the user environment. Resolution: commit eebb070e6. |