← Back to issue list

Resolve xml2-config FIXME in Catkin plugin

View original Github issue

Metadata

Project
snapcraft
Number
#158
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit2949b18fc (merge b98a17057, branch fix_xml2-config): the xml2-config/xslt-config FIXME workaround was moved from the Catkin plugin into the roscore plugin.

Resolution: closed resolved

Reason: The PR was merged into master via commit b98a17057 (merge of kyrofa/fix_xml2-config, change commit 2949b18fc 'Fix up the xml2-config and xslt-config tools to ensure they get the right directory'), a2-file +1/-4 edit that relocated the hack to roscore. Reviewed and approved by @come-maiz.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This simply moves the hack into the roscore plugin, which already has more of them anyway.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit2949b18fc (merge b98a17057, branch fix_xml2-config): the xml2-config/xslt-config FIXME workaround was moved from the Catkin plugin into the roscore plugin.
stealth/space-bunny-alpha — closed resolved Merged PR #158 (commit 79a1a8297, merge b98a17057) resolved the xml2-config FIXME in the Catkin plugin by moving the hack into the roscore plugin (+1/-4, 2 files).
stealth/space-bunny-alpha — closed resolved Merged: moved the xml2-config workaround from the Catkin plugin into the roscore plugin, resolving the FIXME with a two-file, +1/-4 change.
qwen/qwen3.6-35b-a3b — — Merged a fix resolving a xml2-config FIXME by relocating the workaround from the Catkin plugin to the roscore plugin, which already hosts similar hacks. Approved by @come-maiz. The change modifies two files with a net three-line reduction.
qwen3.6-35b-a3b-mtp-q6 — — Merged a resolution for the xml2-config FIXME in the Catkin plugin by relocating the workaround to the roscore plugin. Approved by @come-maiz and successfully merged.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#1181 (confidence 30%)

    Commit 5e3eada39 ('repo: fixup with python, not sed (#1181)') later replaced these same sed-based xml2-config/xslt-config fixups with Python logic, though in the much later legacy repo.

Related issues

Issue Project State Summary Similarity
#181 Backport to 1.x: Resolve FIXME in Catkin plugin snapcraft merged PR #181 merged the #158 Catkin xml2-config FIXME fix into Snapcraft 1.x; implementation commit: 79a1a8297.
71%