← Back to issue list

Backport to 1.x: Resolve FIXME in Catkin plugin

View original Github issue

Metadata

Project
snapcraft
Number
#181
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged a backport of PR #158 to the 1.x branch, resolving a FIXME in the Catkin plugin. The update modified two files with a net change of -3 lines.

Suggested action: —

No scores available.

Issue body

Backport of #158 for 1.x.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged a backport of PR #158 to the 1.x branch, resolving a FIXME in the Catkin plugin. The update modified two files with a net change of -3 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged backport of PR #158 to the 1.x branch, resolving a FIXME in the Catkin plugin. The maintainer-authored change was successfully integrated into the legacy release line.
qwen3.6-35b-a3b-mtp-q6 — — Merged as a backport to the 1.x branch, resolving a FIXME in the Catkin plugin by applying changes from original PR #158.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#196 Backport to 1.x: Catkin plugin: Improve cmake path rewrite. snapcraft merged Merged backport of PR #195 to the 1.x branch. Updates the Catkin plugin to improve cmake path rewriting, changing two files (+57/-35).
85%
#184 Backport to 1.x: Catkin plugin: Refactor build. snapcraft merged Merged backport of PR #175 to the 1.x branch, refactoring the Catkin plugin build across three files. Changes applied directly without reviewer comments or CI checks.
84%
#219 Backport to 1.x: Replace use of `assert_not_called` in the catkin tests snapcraft merged Merged PR #200 backport to the 1.x branch, replacing assert_not_called calls in catkin tests. The change updated one file with six additions and three deletions, successfully applying the test fix to the legacy release line.
79%
#183 Backport to 1.x: Catkin plugin: use rosdep for dependency resolution. snapcraft merged Merged backport of #163 to the 1.x branch. The catkin plugin now uses rosdep for dependency resolution, updating three files with 547 additions and 147 deletions.
77%
#180 Backport to 1.x: Catkin plugin: Add support for ROS tools. snapcraft merged Merged backport of #152 to the 1.x branch, adding ROS tool support to the Catkin plugin. The update modified four files with 112 additions and 28 deletions, successfully integrating the feature.
75%
#347 Backport to 1.x: CMake plugin: Automatically find staged libs and files. snapcraft merged Merged a backport of #345 to the 1.x branch. The CMake plugin now automatically locates staged libraries and files, updating two files with 62 additions and 7 deletions. A minor lint warning was noted but did not block integration.
74%
#292 Backport to 1.x: Fix ordering for conditional negations in catkin tests snapcraft merged Merged as a backport of #199 to the 1.x branch. Resolves an ordering issue with conditional negations in catkin tests. Approved by @sergiusens and verified after retriggering example tests.
72%
#244 Backport to 1.x: Go plugin creating invalid env snapcraft merged Merged a backport of PR #161 to the 1.x branch, resolving a bug where the Go plugin generated an invalid environment. The fix required minimal changes across two files.
70%