← Back to issue list

Backport to 1.x: Resolve FIXME in Catkin plugin

View original Github issue

Metadata

Project
snapcraft
Number
#181
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

PR #181 merged the #158 Catkin xml2-config FIXME fix into Snapcraft 1.x; implementation commit: 79a1a8297.

Resolution: closed resolved

Reason: PR #181 was merged, completing the 1.x backport. Commit 79a1a8297, "Resolve FIXME in Catkin plugin," moves the xml2-config workaround into the roscore plugin.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Backport of #158 for 1.x.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #181 merged the #158 Catkin xml2-config FIXME fix into Snapcraft 1.x; implementation commit: 79a1a8297.
stealth/space-bunny-alpha — closed resolved Merged into 1.x as #181 via commit 79a1a8297, backporting #158 to resolve the Catkin plugin's xml2-config FIXME.
qwen/qwen3.6-35b-a3b — — Merged a backport of PR #158 to the 1.x branch, resolving a FIXME in the Catkin plugin. The update modified two files with a net change of -3 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged backport of PR #158 to the 1.x branch, resolving a FIXME in the Catkin plugin. The maintainer-authored change was successfully integrated into the legacy release line.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft#158 (confidence 100%)

    PR #181 explicitly backports the Catkin xml2-config fix merged in #158.

Related issues

Issue Project State Summary Similarity
#184 Backport to 1.x: Catkin plugin: Refactor build. snapcraft merged PR #184 merged into 1.x, backporting #175’s Catkin build refactor to simplify build logic and dependency handling.
78%
#196 Backport to 1.x: Catkin plugin: Improve cmake path rewrite. snapcraft merged Merged #196 into 1.x, backporting #195’s robust CMake path rewrite so Catkin Config.cmake files correctly target the install directory.
76%
#292 Backport to 1.x: Fix ordering for conditional negations in catkin tests snapcraft merged Merged into snapcraft 1.x via PR #292, backporting PR #199’s two-line fix for conditional-negation ordering in catkin tests.
74%
#183 Backport to 1.x: Catkin plugin: use rosdep for dependency resolution. snapcraft merged Merged into 1.x via PR #183, backporting PR #163 so Catkin uses rosdep instead of manually parsing package.xml dependencies.
73%
#175 Catkin plugin: Refactor build. snapcraft merged Merged in snapcraft#175 via commit 9045874fd, refactoring Catkin environment, dependency handling, build logic, source-space support, and tests.
72%
#158 Resolve xml2-config FIXME in Catkin plugin snapcraft merged Merged as commit2949b18fc (merge b98a17057, branch fix_xml2-config): the xml2-config/xslt-config FIXME workaround was moved from the Catkin plugin into the roscore plugin.
71%
#347 Backport to 1.x: CMake plugin: Automatically find staged libs and files. snapcraft merged Merged into 1.x as snapcraft#347, backporting #345 so the CMake plugin automatically locates staged libraries and files.
71%