← Back to issue list

ament plugin: new plugin

View original Github issue

Metadata

Project
snapcraft
Number
#1583
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 23c22fef3: adds beta ament plugin bootstrapping ROS 2 to build source parts, resolving LP #1686850 and issue #1443.

Resolution: closed resolved

Reason: The PR itself was merged into master with commit 23c22fef3 ("ament plugin: new plugin (#1583)"), adding snapcraft/plugins/ament.py plus integration tests. It implements the beta ROS 2/ament plugin on top of the ROS 2 bootstrapper added in #1582 (ebb2980cc) and closes LP #1686850 / issue #1443.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- As ROS2 nears a stable release, it's a good time to introduce support for it by way of a beta plugin. This PR resolves LP: [#1686850](https://bugs.launchpad.net/snapcraft/+bug/1686850) (and #1443) by doing exactly that. We're starting simple, just bootstrapping ROS2 and using it to build the provided source. ROS2 doesn't have a lot of tooling just yet, so this plugin will need to grow with it. Note that the high line count is due to an integration test: the plugin itself is relatively small.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 23c22fef3: adds beta ament plugin bootstrapping ROS 2 to build source parts, resolving LP #1686850 and issue #1443.
stealth/space-bunny-alpha — closed resolved Merged PR #1583 (commit 23c22fef3), adding a beta ament plugin that bootstraps ROS 2 and builds source packages with it, resolving LP #1686850 and issue #1443.
qwen/qwen3.6-35b-a3b — — Merged a new ROS2 Ament plugin for Snapcraft, resolving LP: #1686850. The PR bootstraps ROS2 and builds source packages. Test failures from ROS repository key errors and a rebase conflict were fixed prior to approval and merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged to add the ament plugin for ROS2 support in snapcraft, resolving LP: #1686850. The update implements ROS2 bootstrapping and build workflows. Pre-merge fixes addressed GPG key errors and test failures caused by rebase conflicts.

Update history

No update history recorded yet.

Related work

  • Duplicate Of: canonical/snapcraft#1443 (confidence 95%)

    Feature request 'new ament plugin (ros2)' was closed by this PR, per its description.

  • Likely Fixed By: canonical/snapcraft#1582 (confidence 90%)

    Commit ebb2980cc added the ROS 2 bootstrapper that the ament plugin uses to pull/build the ROS 2 underlay.

  • Related To: canonical/snapcraft#2324 (confidence 85%)

    Commit 745c4d311 later removed the ament plugin for base-based projects, superseding it.

  • Related To: canonical/snapcraft#2211 (confidence 70%)

    Commit bdaa8ea52 added a spread test suite for the ament plugin.

Related issues

Issue Project State Summary Similarity
#1582 plugins: add ros2 boostrapper snapcraft merged Merged ROS 2 underlay bootstrap code, providing a source-build path for the planned Ament plugin in commit ebb2980cc (PR #1582).
79%
#1443 new ament plugin (ros2) snapcraft closed ROS 2 ament support was added by merged PR #1583 (commit 23c22fef3), with ROS 2 bootstrapping in #1582. PR #2324 later removed ament for base-based builds.
77%
#1686850 Missing support for ament snapcraft (launchpad) closed Added ROS 2 support: merged PR #1583 (commit 23c22fef3) introduced the beta ament plugin, with ROS 2 underlay bootstrapping in #1582, closing LP #1686850 and snapcraft#1443. Later #2324 removed ament for base-based builds.
73%
#1745629 Update ament plugin: ROS2 is now stable snapcraft (launchpad) closed Implemented by PR #1583 (23c22fef3), with ament-plugin spread tests added by PR #2211 (bdaa8ea52); the legacy plugin was later removed for base builds.
72%