plugins: remove the ament plugin when using a base
Metadata
Current evaluation
Merged. Removed the deprecated ament plugin from snapcraft in favor of newer bases. Legacy mode support is preserved for backward compatibility. Approved by reviewer and passed CI checks.
Suggested action: —
No scores available.
Issue body
The ament plugin has been deprecated upstream in favour of a newer
plugin. Use the opportunity of the introduction of bases to remove
support for this plugin from snapcraft.
The spread tests will ensure it continues to work when triggering legacy
mode but will only run a `snapcraft pull` to ensure the plugin is still
reachable. For a full run, the tests should be triggered from the legacy
branch of snapcraft.
LP: #1794775
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Removed the deprecated ament plugin from snapcraft in favor of newer bases. Legacy mode support is preserved for backward compatibility. Approved by reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of the deprecated ament plugin when using a base. Legacy mode tests remain for backward compatibility. Store test failures were ignored due to network issues. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of the deprecated ament plugin when using a base. Legacy mode tests remain for backward compatibility. Author ignored unrelated network-related test failures. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2308 plugins: remove the copy plugin when using a base | snapcraft | merged | Merged into master. Removes the copy plugin when a base is specified. Updated spread tests to verify backwards compatibility. Approved by reviewer, passed CI, and integrated with a net reduction of 622 lines across eight files. | |
| #2319 plugins: remove the tar-content plugin when using a base | snapcraft | merged | Merged into master. Removes the tar-content plugin when a base is specified to preserve backwards compatibility. Approved by reviewer, passed CI checks, and increased coverage by 0.03%. | |
| #2329 pluginhandler: remove legacy plugin loading without project | snapcraft | merged | Merged pull request removing legacy plugin loading logic without project support, aligning with the move to bases. Approved by maintainer, passed CI, and successfully integrated into the codebase. |