plugins: remove the ament plugin when using a base
Metadata
Current evaluation
Merged PR #2324 (745c4d311), removing deprecated ament plugin support for base-based builds while retaining legacy-mode reachability through spread tests.
Resolution: closed resolved
Reason: PR #2324 was approved and merged as commit 745c4d311. The change removes the deprecated plugin from base-based builds and adjusts spread coverage for legacy mode.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The ament plugin has been deprecated upstream in favour of a newer
plugin. Use the opportunity of the introduction of bases to remove
support for this plugin from snapcraft.
The spread tests will ensure it continues to work when triggering legacy
mode but will only run a `snapcraft pull` to ensure the plugin is still
reachable. For a full run, the tests should be triggered from the legacy
branch of snapcraft.
LP: #1794775
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2324 (745c4d311), removing deprecated ament plugin support for base-based builds while retaining legacy-mode reachability through spread tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2324 (745c4d311) removed deprecated ament plugin support for base-based builds while preserving its legacy-mode reachability through spread tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Removed the deprecated ament plugin from snapcraft in favor of newer bases. Legacy mode support is preserved for backward compatibility. Approved by reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of the deprecated ament plugin when using a base. Legacy mode tests remain for backward compatibility. Store test failures were ignored due to network issues. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#2211
(confidence 90%)
Merged PR #2211 introduced the ament plugin spread suite referenced by this change's legacy-mode testing.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2308 plugins: remove the copy plugin when using a base | snapcraft | merged | Merged PR #2308 via commit 360453fa6, removing the copy plugin for base-based builds while preserving and testing legacy no-base compatibility. | |
| #1794775 Update the ament plugin to be base aware | snapcraft (launchpad) | closed | Ament base support was resolved by removing the plugin for base-based builds in merged snapcraft#2324 (745c4d311); it remained available only in legacy mode. | |
| #2325 plugins: remove the python2 and python3 plugin when using a base | snapcraft | merged | Merged #2325 in commit 958b58615, removing deprecated python2/python3 plugins for base builds and retaining legacy-mode regression coverage for the unified python plugin. | |
| #2370 ant plugin: add support for bases | snapcraft | merged | Merged via commit eab7fcf15: made the ant plugin base-aware, supporting only core16 and core18, and updated its tests/spread coverage. Closes Launchpad bug #1794776. |