← Back to issue list

tests: move ruby demo test to snapd integration suite

View original Github issue

Metadata

Project
snapcraft
Number
#1596
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

PR #1596 merged (commit 535b8db63): moved the Ruby demo test out of snapcraft's integration suite into snapd's, and fixed the command in the ruby-hello demo snap.

Resolution: closed resolved

Reason: The PR was merged into snapcraft after approval by two reviewers, landing as commit 535b8db63. Its stated goal — relocating the Ruby demo test to snapd's integration suite plus correcting the ruby-hello snap command — was completed by the merge itself.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- This also fixes the command in the ruby-hello snap.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #1596 merged (commit 535b8db63): moved the Ruby demo test out of snapcraft's integration suite into snapd's, and fixed the command in the ruby-hello demo snap.
stealth/space-bunny-alpha — closed resolved Merged in #1596 (commit 535b8db63), moving the Ruby demo test to snapd’s integration suite and fixing the ruby-hello snap command.
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI. Relocated the ruby demo test to the snapd integration suite and corrected a command in the ruby-hello snap. Modified four files with minimal line changes.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes moving the Ruby demo test to the snapd integration suite and correcting the ruby-hello snap command.

Update history

No update history recorded yet.

Related work

  • Related To: snapcore/snapd (confidence 60%)

    The Ruby demo test was relocated into snapd's integration suite, tying the change to that upstream suite.

Related issues

Issue Project State Summary Similarity
#1552 tests: replace the first batch of demo tests with snapd integration tests snapcraft merged Merged PR #1552 (commit efa8927e8): replaced the first batch of demo integration tests with a new snapd integration suite that builds, installs and runs Python hello-world snaps; the opencv demo test was kept after review.
77%
#1849 tests: add snap not found tests snapcraft merged Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e.
71%
#1625 tests: use the snapcraft snap for integration tests snapcraft merged Merged PR #1625 updated integration tests to run the installed Snapcraft snap, better matching the user environment. Resolution: commit eebb070e6.
70%
#2212 tests: add spread suite for ruby plugin snapcraft merged Merged PR snapcore/snapcraft#2212 (commit b7729970a) adds a Spread suite for the Ruby plugin, replacing the Python/snapd integration test; closes LP #1783840.
70%